Skip to content

Driver is called when nothing is changed in volume resize wizard - #14259

Open
sathvikaragi wants to merge 1 commit into
apache:mainfrom
NetApp:handle-volume-resize-no-changes
Open

sathvikaragi wants to merge 1 commit into
apache:mainfrom
NetApp:handle-volume-resize-no-changes

Conversation

@sathvikaragi

@sathvikaragi sathvikaragi commented Sep 29, 2026 •

Copy link
Copy Markdown

Description

Calling resizeVolume with the existing volume details and not changing anything in wizard still invoked the storage driver, causing an unnecessary driver resize request for volumes.

fixes : #14260

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

actually resizes (In backend driver call is made and in UI also we can see it is resizing)
Screenshot 2026-09-24 at 4 36 00 PM

Shows success immediately:
Screenshot 2026-09-24 at 4 28 37 PM

How Has This Been Tested?

How did you try to break this feature and the system with this change?

#110)

Calling resizeVolume with the existing volume size still invoked the
storage driver, causing an unnecessary driver resize request for
volumes.
### Description

This PR...
<!--- Describe your changes in DETAIL - And how has behaviour
functionally changed. -->

<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to
reproduce. -->

<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically
be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->

<!---
*******************************************************************************
-->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE
DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!---
*******************************************************************************
-->

### Types of changes

- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] Build/CI
- [ ] Test (unit or integration test code)

### Feature/Enhancement Scale or Bug Severity

#### Feature/Enhancement Scale

- [ ] Major
- [ ] Minor

#### Bug Severity

- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X] Minor
- [ ] Trivial

### Screenshots (if appropriate):
Before Patch API is still called in case of no changes in the wizard:
<img width="1423" height="1034" alt="Screenshot 2026-09-24 at 4 33
33 PM"
src="https://github.com/user-attachments/assets/5480986e-bc79-4bc7-b05c-62077c2cc93e"
/>

actually resizes (IN UI)
<img width="1441" height="638" alt="Screenshot 2026-09-24 at 4 36 00 PM"
src="https://github.com/user-attachments/assets/8430eaa3-947e-41d4-8573-518f7831d7f0"
/>


after the fix Patch api is not called :
<img width="1393" height="1035" alt="Screenshot 2026-09-24 at 4 17
52 PM"
src="https://github.com/user-attachments/assets/b53e1146-560a-437a-9b0c-501be9ec4d76"
/>

Shows success immediately:
<img width="1471" height="728" alt="Screenshot 2026-09-24 at 4 28 37 PM"
src="https://github.com/user-attachments/assets/9cdd57b0-2b1f-4550-9830-46f87c439061"
/>



### How Has This Been Tested?

<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran
to -->

#### How did you try to break this feature and the system with this
change?

<!-- see how your change affects other areas of the code, etc. -->

<!-- Please read the
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
document -->
@sathvikaragi sathvikaragi changed the title when nothing is changed in volume resize wizard directl… Driver is called when nothing is changed in volume resize wizard Sep 29, 2026
@sathvikaragi
sathvikaragi marked this pull request as ready for review September 29, 2026 06:29
@sathvikaragi

Copy link
Copy Markdown
Author

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@codecov

codecov Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 19.91%. Comparing base (510d0ec) to head (762a4c9).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...n/java/com/cloud/storage/VolumeApiServiceImpl.java 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main   #14259   +/-   ##
=========================================
  Coverage     19.91%   19.91%           
- Complexity    20194    20197    +3     
=========================================
  Files          6373     6373           
  Lines        577230   577231    +1     
  Branches      70696    70697    +1     
=========================================
+ Hits         114942   114958   +16     
+ Misses       449722   449707   -15     
  Partials      12566    12566           
Flag Coverage Δ
uitests 3.71% <ø> (ø)
unittests 21.18% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Driver is called when nothing is changed in volume resize wizard

2 participants