Conversation
Document the existing keyless authentication path and cover ADC selection, explicit service-account key precedence, and ADC failure propagation. Co-authored-by: Codex <noreply@openai.com> Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
Contributor
|
🧪 CI tested the following changed modules:
🔬 Scalpel shadow comparison — Scalpel: 9 of 698 tested, 26 compile-only — current: 9 all testedMaveniverse Scalpel detected 9 affected modules (current approach: 9). Skip-tests mode would test 9 modules (2 direct + 8 downstream), skip tests for 26 (generated code, meta-modules) Modules Scalpel would test (9)
Modules with tests skipped (26)
All tested modules (36 modules, 5m 31s total)Total reactor time: 5m 31s
Top 20 slowest modules:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Google Functions already falls back to Application Default Credentials when no
serviceAccountKeyis supplied, but its guide only describes key-file authentication. This documents keyless GKE workload identity, credential precedence, and a route using the pod identity.Adds factory tests proving ADC credentials reach the client, an explicit key bypasses ADC, and credential lookup failures propagate without creating a client. Includes the mirrored catalog documentation. Authentication behavior is unchanged.
Validation: Functions module tests and formatter/import sorter passed (24 tests, zero failures/errors, one existing disabled test). The full 692-module reactor build passed with
mvn -Dquickly install(tests skipped in that build).Live GKE verification remains outstanding: this workspace has no configured Google Cloud project or
kubectl. This draft addresses the original GKE/ADC scope of CAMEL-17368; explicit WIF endpoint options are outside this changeset.AI-generated by Codex on behalf of oscerd.
Generated by Codex via OSS Helper