Conversation
shunping
marked this pull request as ready for review
October 1, 2026 14:17
Collaborator
Author
|
cc'ed @chamikaramj @damccorm This addressed the performance regression of rename op in GcsUtilV2 by parallelizing the rewrites. |
Contributor
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Collaborator
Author
|
assign set of reviewers |
Contributor
|
Assigning reviewers: R: @ahmedabu98 for label java. This pull request likely touches a core component ("core" label). Please review with scrutiny. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GcsUtilV2.rewriteHelperpreviously processed files sequentially, making up to three dependent RPCs per file (target lookup, rewrite, and source delete). Unlike V1, which batches rewrites and runs batches concurrently, V2'sjava-storageclient does not support rewrite inStorageBatch, causingrenameto be ~6x slower than V1 in 64-shardParquetIOLTbenchmarks.GcsUtilV2: extract per-file logic intorewriteOneand execute multi-filecopy/movecalls concurrently on a bounded thread pool (up to 32 threads). Propagate the caller'sMetricsContainerto worker threads, cancel unstarted tasks on the first failure, and rethrow the original exception type (FileNotFoundException,FileAlreadyExistsException,AccessDeniedException, etc.) with subsequent failures attached as suppressed.GcsUtilV2Test: addtestV2RenameRewritesFilesConcurrentlyandtestV2RenameFailuresAreReportedPerFile.In the 64-shard
ParquetIOLT(f1_s1k) write benchmark on Dataflow, V2gcs_op_rename_msecdropped from ~20.6s to ~1.0s (vs ~2.3s–2.9s on V1) after this change.