Go SDK: reject a task function whose last result type is not error - #74077
Merged
henry3260 merged 1 commit intoOct 3, 2026
Merged
Conversation
Signed-off-by: PoAn Yang <payang@apache.org>
FrankYang0529
marked this pull request as ready for review
October 3, 2026 00:06
FrankYang0529
requested review from
amoghrajesh,
ashb and
jason810496
as code owners
October 3, 2026 00:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to Reject invalid registrations at registration time, which #73549 addressed. That item lists a wrong return shape among the signature errors that should fail at registration. Registration still accepted one kind of signature that makes every run of the task fail.
Why
A task function can declare its last result as a concrete type that implements
errorlikefunc(airflow.Context) (int, *MyErr). Registration accepts the function. When the task runs, the Go SDK reads the last result into anerrorvalue. A nil*MyErrthen becomes a non-nilerror. So the task fails on every run, even when the function returns nil.How
Change
internal/bundleto require the last result of a task function to have the typeerroritself.Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.