Skip to content

Configurable vod directory per application, with backward compat - #7958

Open
jantekb wants to merge 7 commits into
masterfrom
feature/vod-directory
Open

jantekb wants to merge 7 commits into
masterfrom
feature/vod-directory

Conversation

@jantekb

@jantekb jantekb commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

#7868

  • removes unnecessary import REST API call
  • provides backward compatibility if unset
  • does not affect ongoing HLS streaming that still uses the streams folder for temporary assets

@jantekb
jantekb force-pushed the feature/vod-directory branch from 7895802 to 92eae9f Compare July 22, 2026 13:48
@jantekb
jantekb marked this pull request as draft July 24, 2026 12:27
@jantekb
jantekb marked this pull request as ready for review July 24, 2026 12:27
@jantekb

jantekb commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

The quality gate problems were addressed in a separate PR

@jantekb
jantekb force-pushed the feature/vod-directory branch from 1c44a2b to 04557f1 Compare July 24, 2026 12:31
@sonarqubecloud

Copy link
Copy Markdown

@Path("/directory")
@Produces(MediaType.APPLICATION_JSON)
@Override
public Result importVoDs(

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@burak-58 I understand that in principle we minimize changes to the rest API and keep things backward compatible, but in this particular case I see no way to keep this method here. The work is about to eliminate the concept of linked vod directories, so it has to be reflected in the API - any if we keep a backward compatible "ok"-ish response, that can cause more harm to customers than removing it. We need to increment the minor version in our semver to express the incompatibility and by removing the actual method, we make sure that it cannot go unnoticed on user end after an upgrade.

@jantekb jantekb left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment on the removal of the rest api methods

@jantekb
jantekb force-pushed the feature/vod-directory branch from 04557f1 to 1f24ac7 Compare September 16, 2026 07:47
Comment thread src/main/java/io/antmedia/AntMediaApplicationAdapter.java Fixed
Comment thread src/main/java/io/antmedia/AntMediaApplicationAdapter.java Fixed
@sonarqubecloud

sonarqubecloud Bot commented Oct 6, 2026

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants