fix(tui): use path.sep for plugin name extraction in /status dialog - #52328
Merged
Merged
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #46101
Type of change
What does this PR do?
On Windows,
fileURLToPath()returns backslash-separated paths, but the status dialog was splitting on/only. The entire path became a single token, and the first.in.configmade the displayed nameC:\Users\Administrator\instead ofrtk.Changed
split("/")tosplit(path.sep)and renamed the local variable to avoid shadowing thepathmodule import.How did you verify your code works?
Ran a Node script comparing old vs new logic on a Windows path:
C:\Users\Administrator\rtkScreenshots / recordings
See screenshot in linked issue #46101.
Checklist
History: This bug was reported in #34141 and two prior PRs attempted to fix it (#33375, #34183). Both were closed without merging. The bug still exists on dev, re-reported as #46101. Previous PR #46114 was auto-closed by the cleanup bot.