-
Notifications
You must be signed in to change notification settings - Fork 219
Update to angular 21 #531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shlomoa
wants to merge
25
commits into
angular-split:main
Choose a base branch
from
shlomoa:update_to_angular_21
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+10,784
−11,527
Open
Update to angular 21 #531
Changes from 11 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
2124b4c
added copilot instructions
shlomoa 0df4960
build: restore dependencies (npm install)
shlomoa 47e87ed
build(deps): update Angular Core and CLI to v20
shlomoa 8280721
build(deps): update angular-eslint packages to v20
shlomoa d2f904a
build(deps): update ngx-bootstrap to v20
shlomoa 9d52b5c
build: update to Angular 20 and fix build scripts
shlomoa 7d9bd0d
build: update to Angular 21
shlomoa 91fdd3a
build: finalize Angular 21 update
shlomoa 6984d24
docs: update CHANGELOG for Angular 21 update
shlomoa 06022b1
ci: update node versions for Angular 21
shlomoa e5f1d20
Merge pull request #1 from shlomoa/update_to_angular_21
shlomoa 05f9ed2
build: update supported node versions to 24
shlomoa 2544c03
build: additional updates (to be stashed in rebase)
shlomoa 54048ac
Merge branch 'main' into update_to_angular_21
SanderElias 1c428b2
Merge branch 'main' into update_to_angular_21
SanderElias 01df0d3
Merge branch 'main' into update_to_angular_21
SanderElias f945a47
fix(packaging): fixed issues flaged by github AI agent
shlomoa a205db9
Merge branch 'update_to_angular_21' of https://github.com/shlomoa/ang…
shlomoa 3910106
fix(build): fixed all AI requirements
shlomoa 99d4cb6
fix: enabled cleaner install
shlomoa bc13682
fix: updated several package versions
shlomoa 19150c7
Merge branch 'main' into pr/shlomoa/531
shlomoa 04bf5df
fix: updated configuration files
shlomoa 7b02025
fix: handle async marked.parse result
shlomoa a310dd9
fix: fixed strict linting issues
shlomoa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| # Copilot Instructions — angular-split | ||
|
|
||
| Quick-start operating manual for this repo. | ||
| Rules are repo specific and override any general rules you may have been trained on. | ||
|
|
||
| - applicable to git branch update_to_angular_21 | ||
| - This document should be constantly revised and updated. | ||
|
|
||
| There are two main sections in this document representing two strategies for working with github copilot: | ||
| - Interactive via chat mode of operation rules | ||
| - Automatic (code generation) mode of operation rules | ||
|
|
||
| # expectations from github copilot | ||
| Always ask user for guidance. | ||
| - Provide best in class respose: | ||
| - accurate, correct, complete, concise, clear, and relevant. | ||
| - Provide best in class code: | ||
| - correct, clean, efficient, and well documented. | ||
| - Learn cutting edge techniques - ask user for guidance. | ||
| - Use best known methods and practices - | ||
|
|
||
| # purpose of this activity | ||
| - Update the codebase to Angular 21. | ||
| - Update all dependencies to their latest versions as possible. | ||
|
|
||
| # Interactive (chat) mode of operation rules | ||
|
|
||
| ## KISS rules (general) | ||
| KISS stands for "Keep It Stupid Simple". This is a design principle that states that most systems work best if they are kept simple. | ||
| Simple is: | ||
| - minimal in code and features. | ||
| - using existing reusable components or create reusable components when needed. | ||
| - structured in a way that is: | ||
| - easy to navigate and maintain. | ||
| - built correctly the first time - correct by construction. | ||
| - always verifiable | ||
| Stupid is: | ||
| - not over-engineered. | ||
| - not over-complicated. | ||
| - not over-designed. | ||
| - every dummy even github copilot could understand it. | ||
|
|
||
| ## Single sources of truth | ||
| Respect the single source of truth principle. definitions are made once in a single place, further use of this definition is done by referencing (for documenting) or importing (in code). | ||
|
|
||
| ## Collaboration rules (repo‑specific) | ||
| - read user instructions carefully. | ||
| - fix typos in them. | ||
| - clarify any: | ||
| - ambiguities. | ||
| - missing information. | ||
| - elaborate on any: | ||
| - vague instructions. | ||
| - incomplete instructions. | ||
| - discuss options with the user, if there are any. | ||
| - Develop a detailed plan with the user, that includes: | ||
| - tasks, sub tasks | ||
| - validation steps in all stages of the process. | ||
| - enumerated action plan. | ||
|
|
||
| ## Mode of operation | ||
| - Stop if context is unclear. | ||
| - Start by gaining context - ask user for help. | ||
| - Wait for user instructions. | ||
| - Execute plans for actions. | ||
| - Validate results with the user. | ||
| - Document everything. | ||
|
|
||
| # Automatic (code generation) mode of operation rules | ||
|
|
||
| None yet. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -41,4 +41,5 @@ testem.log | |
| # System Files | ||
| .DS_Store | ||
| Thumbs.db | ||
| .wireit | ||
| .wireit | ||
| PLAN.md | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.