Skip to content

feat: modernize angular split #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jefiozie merged 14 commits into from
Jul 10, 2024
Merged

feat: modernize angular split #444

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
f36da15
feat: modernize angular split
Harpush May 27, 2024
45db74b
fix: typo, left click check not needed
Harpush Jun 12, 2024
5fc3aa9
fix: force gutter events cancellation when inputs change affects sizes
Harpush Jun 12, 2024
b06ea6d
fix: remove not needed take inside takeUntil
Harpush Jun 12, 2024
15f2f11
fix: pack inputs together
Harpush Jun 12, 2024
28002a2
fix: add min/max classes only when area visible
Harpush Jun 12, 2024
cedf889
fix: normalize min/max size based on outer size
Harpush Jun 12, 2024
2f30982
fix: typos
Harpush Jun 12, 2024
bff7d73
fix: delta check with custom gutter
Harpush Jun 12, 2024
f55e174
feat: merge and apply css variables
Harpush Jun 12, 2024
fe906b4
Revert "fix: force gutter events cancellation when inputs change affe…
Harpush Jun 12, 2024
8d6d10d
fix: minor fixes (typos, unused code)
Harpush Jun 15, 2024
4ee3e27
feat: support hierarchical inheritance in options
Harpush Jun 16, 2024
19502de
fix: typo in config token comment
Harpush Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: typos
  • Loading branch information
@Harpush
Harpush committed Jun 12, 2024
commit 2f3098278b9aa07e7a9f18cbf188f1dea8c81f1c
2 changes: 1 addition & 1 deletion projects/angular-split/src/lib/split-custom-events-behavior.directive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import { SplitComponent } from './split/split.component'
*
* Emulates browser behavior of click and double click with new features:
* 1. Supports touch events (tap and double tap)
* 2. Ignores the first click in a double click with the side effect of a bit slower emission of fast click event
* 2. Ignores the first click in a double click with the side effect of a bit slower emission of the click event
* 3. Allow customizing the delay after mouse down to count another mouse down as a double click
*/
@Directive({
Expand Down
2 changes: 1 addition & 1 deletion src/app/examples/gutter-click-roll-unroll/gutter-click-roll-unroll.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ export class GutterClickRollUnrollComponent extends AComponent implements AfterV

setTimeout(() => {
if (this.logsEl.nativeElement.scroll) {
;(<HTMLElement>this.logsEl.nativeElement).scroll({ top: this.logMessages.length * 30 })
(<HTMLElement>this.logsEl.nativeElement).scroll({ top: this.logMessages.length * 30 })
}
})

Expand Down
2 changes: 1 addition & 1 deletion src/app/examples/split-transitions/split-transitions.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ export class SplitTransitionsComponent extends AComponent {
this.logMessages.push({ type: 'transitionEnd', text: `${formatDate(new Date())} > transitionEnd event > ${e}` })
setTimeout(() => {
if (this.logsEl.nativeElement.scroll) {
;(<HTMLElement>this.logsEl.nativeElement).scroll({ top: this.logMessages.length * 30 })
(<HTMLElement>this.logsEl.nativeElement).scroll({ top: this.logMessages.length * 30 })
}
})
}
Expand Down