Skip to content

Revert: "feat: add tabindex input and binding" #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jefiozie merged 1 commit into from
May 20, 2024
Merged

Revert: "feat: add tabindex input and binding" #440

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Revert "feat: add tabindex input and binding (#438)" 
This reverts commit 1d259cf.
  • Loading branch information
@Jefiozie
Jefiozie authored May 15, 2024
commit 740ea79d959a5f156f5d8856102e0270bec5a4c0
5 changes: 1 addition & 4 deletions projects/angular-split/src/lib/component/split.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import {
Inject,
Optional,
ContentChild,
numberAttribute,
} from '@angular/core'
import { Observable, Subscriber, Subject } from 'rxjs'
import { debounceTime } from 'rxjs/operators'
Expand Down Expand Up @@ -96,7 +95,7 @@ import { SplitGutterDirective } from '../gutter/split-gutter.directive'
>
<div
role="separator"
[tabindex]="tabindex"
tabindex="0"
*ngIf="last === false"
#gutterEls
class="as-split-gutter"
Expand Down Expand Up @@ -158,8 +157,6 @@ export class SplitComponent implements AfterViewInit, OnDestroy {
return this._direction
}

@Input({ transform: numberAttribute }) tabindex: number = 0

@Input() set unit(v: ISplitUnit) {
this._unit = v === 'pixel' ? 'pixel' : 'percent'

Expand Down