Skip to content

feat: introduce eslint and remove tslint closes (#374) #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jefiozie merged 9 commits into from
Jan 23, 2024
Merged

feat: introduce eslint and remove tslint closes (#374) #382

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f902941
feat: introduce eslint to the project
Jefiozie Jan 23, 2024
d828577
fix: resolve linting rules
Jefiozie Jan 23, 2024
5feb495
Merge remote-tracking branch 'origin/main' into feat/eslint
Jefiozie Jan 23, 2024
a491b2d
fix: resolve linting rules for app and exclude nx
Jefiozie Jan 23, 2024
13a4158
fix: resolve linting rules for app
Jefiozie Jan 23, 2024
3ef5959
fix: resolve type issues
Jefiozie Jan 23, 2024
dfa682d
feat: introduce explicit member rule
Jefiozie Jan 23, 2024
921015e
chore: update git hook to run lint commiting
Jefiozie Jan 23, 2024
a6d8e12
chore: set husky as a prepare step so that hook will be handled
Jefiozie Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: resolve linting rules for app and exclude nx
  • Loading branch information
@Jefiozie
Jefiozie committed Jan 23, 2024
commit a491b2d122410c81fb1ec530c1d49632972ebcde
17 changes: 13 additions & 4 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,13 @@
{
"root": true,
"ignorePatterns": ["projects/**/*"],
"ignorePatterns": [
"projects/**/*"
],
"overrides": [
{
"files": ["*.ts"],
"files": [
"*.ts"
],
"extends": [
"eslint:recommended",
"plugin:@typescript-eslint/recommended",
Expand All @@ -30,8 +34,13 @@
}
},
{
"files": ["*.html"],
"extends": ["plugin:@angular-eslint/template/recommended", "plugin:@angular-eslint/template/accessibility"],
"files": [
"*.html"
],
"extends": [
"plugin:@angular-eslint/template/recommended",
"plugin:@angular-eslint/template/accessibility"
],
"rules": {}
}
]
Expand Down
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
!.vscode/extensions.json

# misc
/.nx/*
/.angular/cache
/.sass-cache
/connect.lock
Expand Down
Loading