fix(client:auth): redirect a logged-in user when visits a guest page …

…like /login or /signup
angular-fullstack · mtvs · Jun 20, 2016 · Jul 25, 2016 · Jul 25, 2016 · Jul 25, 2016
commit 307898feea66958574fa859723e8a6cb27f233c8
diff --git a/templates/app/client/app/account(auth)/account.routes.js b/templates/app/client/app/account(auth)/account.routes.js
@@ -8,7 +8,8 @@ export default function routes($stateProvider) {
         url: '/login',
         template: require('./login/login.<%= templateExt %>'),
         controller: 'LoginController',
-        controllerAs: 'vm'
+        controllerAs: 'vm',
+        guest: true
       })
       .state('logout', {
         url: '/logout?referrer',
@@ -27,7 +28,8 @@ export default function routes($stateProvider) {
         url: '/signup',
         template: require('./signup/signup.<%= templateExt %>'),
         controller: 'SignupController',
-        controllerAs: 'vm'
+        controllerAs: 'vm',
+        guest: true
       })
       .state('settings', {
         url: '/settings',

diff --git a/templates/app/client/components/auth(auth)/router.decorator.js b/templates/app/client/components/auth(auth)/router.decorator.js
@@ -5,35 +5,46 @@ export function routerDecorator($rootScope<% if(filters.ngroute) { %>, $location
   'ngInject';
   // Redirect to login if route requires auth and the user is not logged in, or doesn't have required role
   $rootScope.$on(<% if(filters.ngroute) { %>'$routeChangeStart'<% } %><% if(filters.uirouter) { %>'$stateChangeStart'<% } %>, function(event, next) {
-    if(!next.authenticate) {
-      return;
-    }
+    if(next.authenticate) {
+      if(typeof next.authenticate === 'string') {
+        Auth.hasRole(next.authenticate).then(has => {
+          if(has) {
+            return;
+          }
 
-    if(typeof next.authenticate === 'string') {
-      Auth.hasRole(next.authenticate).then(has => {
-        if(has) {
-          return;
-        }
+          event.preventDefault();
+          return Auth.isLoggedIn().then(is => {
+            <%_ if(filters.ngroute) { _%>
+            $location.path(is ? '/' : '/login');<% } %>
+            <%_ if(filters.uirouter) { _%>
+            $state.go(is ? 'main' : 'login');<% } %>
+          });
+        });
+      } else {
+        Auth.isLoggedIn().then(is => {
+          if(is) {
+            return;
+          }
 
-        event.preventDefault();
-        return Auth.isLoggedIn().then(is => {
+          event.preventDefault();
           <%_ if(filters.ngroute) { _%>
-          $location.path(is ? '/' : '/login');<% } %>
+          $location.path('/login');<% } %>
           <%_ if(filters.uirouter) { _%>
-          $state.go(is ? 'main' : 'login');<% } %>
+          $state.go('login');<% } %>
         });
-      });
-    } else {
+      }
+    }
+    else if(next.guest) {
       Auth.isLoggedIn().then(is => {
-        if(is) {
+        if(!is) {
           return;
         }
 
         event.preventDefault();
         <%_ if(filters.ngroute) { _%>
-        $location.path('/login');<% } %>
+        $location.path('/');<% } %>
         <%_ if(filters.uirouter) { _%>
-        $state.go('login');<% } %>
+        $state.go('main');<% } %>
       });
     }
   });