Skip to content
This repository was archived by the owner on Apr 17, 2026. It is now read-only.

fix #445 and fix #424 download highest sub-patch chromedriver #447

Open
trycatchal wants to merge 2 commits into
base: legacy
Choose a base branch
from
Open

fix #445 and fix #424 download highest sub-patch chromedriver #447

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
887a553
fix #445 download highest sub-patch chromedriver
trycatchal Feb 26, 2020
1470e10
fix lint in chrome_xml
trycatchal Feb 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix #445 download highest sub-patch chromedriver
  • Loading branch information
@trycatchal
trycatchal authored Feb 26, 2020
commit 887a553c3aebd303f16ee8bbf8cbe80245c75587
9 changes: 8 additions & 1 deletion lib/binaries/chrome_xml.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,14 @@ export class ChromeXml extends XmlConfigSource {
// For 64-bit systems, prefer the 64-bit version.
else if (this.osarch === 'x64') {
if (item.includes(this.getOsTypeName() + '64')) {
itemFound = item;
// Only override the previously found item if its sub-patch-version is less
// than that of the current candidate.
const itemFoundVersionParts = itemFound.split('/')[0].split('.');
const versionParts = version.split('.');
if (itemFoundVersionParts.length<4 ||
(parseInt(versionParts[3] || '0')>parseInt(itemFoundVersionParts[3]))) {
itemFound = item;
}
}
}
}
Expand Down