Skip to content
This repository was archived by the owner on Apr 17, 2026. It is now read-only.

feat(selenium-grid): run webdriver-manager as a selenium-grid node (merge against master branch) #386

Open
filipzamorsky wants to merge 13 commits into
base: master
Choose a base branch
from
Open

feat(selenium-grid): run webdriver-manager as a selenium-grid node (merge against master branch) #386

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
29168a4
feat(selenium-grid): Add Selenium grid node support
filipzamorsky May 29, 2019
1dbbcc1
Update git e-mail
filipzamorsky May 29, 2019
500bd1e
feat(selenium-grid): Change variable in selenium-server.ts
filipzamorsky May 29, 2019
9811807
feat(selenium-grid): Change variable and code formatting in selenium_…
filipzamorsky May 29, 2019
253f809
feat(selenium-grid): Update variables
filipzamorsky May 29, 2019
a9193a0
Fix issues after running tests
filipzamorsky May 30, 2019
8c334a7
feat(selenium-grid) Add runAsGrid functionality and fix issues
filipzamorsky May 31, 2019
e2851da
feat(selenium-grid): Write unit test for a selenium grid node option
filipzamorsky May 31, 2019
690e5c4
Reset README.md file
filipzamorsky Jun 13, 2019
4e2ca9d
Merge pull request #7 from angular/master
filipzamorsky Jun 13, 2019
51cbe83
Merge changes from original Master and resolve conflicts
filipzamorsky Jun 13, 2019
db8c837
Resolve suggestions
filipzamorsky Jun 13, 2019
063bd56
Delete empty row at the end of the selenium_server.ts file
filipzamorsky Jun 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat(selenium-grid): Change variable and code formatting in selenium_… 
…server.ts
  • Loading branch information
@filipzamorsky
filipzamorsky authored May 29, 2019
commit 9811807babb7c83604998ba08a20b9cd48a5793d
10 changes: 5 additions & 5 deletions lib/provider/selenium_server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ export class SeleniumServer implements ProviderInterface {
this.runAsNode = providerConfig.runAsNode;
}
if (providerConfig.runAsGrid) {
this.runAsGrid = providerConfig.runAsGrid;
this.grid_node = providerConfig.runAsGrid;
}
if (providerConfig.runAsDetach) {
this.runAsDetach = providerConfig.runAsDetach;
Expand Down Expand Up @@ -199,11 +199,11 @@ export class SeleniumServer implements ProviderInterface {
options.push('0');
}
if (this.runAsGrid) {
options.push('-role');
options.push('node');
options.push('-role');
options.push('node');

options.push('-hub');
options.push(this.runAsNode);
options.push('-hub');
options.push(this.grid_node);
}
options.push('-port');
options.push(this.port.toString());
Expand Down