fix(material/dialog): use a theme token for the backdrop color - #33923
Open
minwookshin wants to merge 1 commit into
Open
minwookshin wants to merge 1 commit into
minwookshin wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #33578
Give Material dialogs a default backdrop class that reads the dialog
scrim-colortoken. The M3 default derives from the system scrim color at 32% opacity; M2 retains its existing black backdrop at 32% opacity. Custom backdrop classes keep their current behavior, and CDK styling is unchanged.This follows the Material-specific
backdropClassapproach discussed in the issue. Added regression coverage for the system scrim color, token overrides, and custom class arrays.Validated the Dialog suite in Chromium and Firefox, the CDK Dialog Chromium suite, Sass theme compilation, formatting, and lint for the changed TypeScript and Sass files. The new default/token assertions fail before the fix. Internal screenshot baselines are left for maintainers to review.