Skip to content

chore: ask in the PR template whether a change is breaking - #3782

Open
armando-navarro wants to merge 1 commit into
angular:mainfrom
armando-navarro:f1-pr-template-breaking-change
Open

armando-navarro wants to merge 1 commit into
angular:mainfrom
armando-navarro:f1-pr-template-breaking-change

Conversation

@armando-navarro

Copy link
Copy Markdown
Collaborator

Fixes #3781

Adds a checklist line to PULL_REQUEST_TEMPLATE.md:

Breaking change?: (yes/no, required. If yes, add a BREAKING CHANGE: footer to your commit message that says what an upgrading app must change, and put ! before the colon in the PR title and the commit subject, like fix(auth)!: ...)

It mentions the commit subject as well as the PR title because a one-commit PR lands on main with its commit's subject, not the PR title. #3772 shows this: its title is "fix(build): order canary builds by commit time", and main has its commit subject instead.

Documentation only. No code or tests change.

The template now asks every PR whether it breaks existing apps,
and if it does, asks for both markers. It mentions the commit
subject as well as the PR title because a one-commit PR lands
on main with its commit's subject.
@armando-navarro armando-navarro added comp: other Doesn't clearly map to a module or cross-cutting area. type: chore Maintenance with no user-facing behavior change. labels Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: other Doesn't clearly map to a module or cross-cutting area. type: chore Maintenance with no user-facing behavior change.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The PR template doesn't ask whether a change is breaking

2 participants