Skip to content

fix(schematics): declare the runtime dependencies the schematics bundle requires #3747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
armando-navarro merged 2 commits into from
Aug 18, 2026
Merged

fix(schematics): declare the runtime dependencies the schematics bundle requires #3747

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e21c25
fix(schematics): declare the runtime dependencies the schematics bund…
armando-navarro Aug 17, 2026
deb882f
Merge branch 'main' into a20-dependency-declarations
armando-navarro Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(schematics): declare the runtime dependencies the schematics bund… 
…le requires

The shipped schematics require jsonc-parser, @angular-devkit/core, and
@angular-devkit/architect at runtime, but the published manifest never
declared them. The first two resolve today only because npm hoists them
from the declared @angular-devkit/schematics and @schematics/angular.
Architect is worse: it is not in the package's dependency closure at
all and resolves from the app's own @angular/cli install, so ng deploy
breaks under pnpm's strict layout or Yarn PnP.

The architect range is the comparator pair matching its 0.YYMM version
scheme. A caret on a 0.x version would lock consumers to Angular 21.0.x.

Also prunes the ng-packagr allowlist to the seven names actually
declared, dropping ten entries for dependencies removed long ago and a
duplicate @schematics/angular.
  • Loading branch information
@armando-navarro
armando-navarro committed Aug 17, 2026
commit 9e21c25bffe90089f2e198c8947b5cdb94131759
7 changes: 2 additions & 5 deletions src/ng-package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,8 @@
},
"dest": "../dist/packages-dist",
"allowedNonPeerDependencies": [
"@angular-devkit/architect", "@angular-devkit/core",
"@angular-devkit/schematics", "@schematics/angular",
"fuzzy", "inquirer-autocomplete-prompt",
"open", "jsonc-parser", "ora", "winston",
"triple-beam", "@schematics/angular", "node-fetch",
"semver", "inquirer", "fs-extra",
"firebase", "rxfire"
"jsonc-parser", "firebase", "rxfire"
]
}
3 changes: 3 additions & 0 deletions src/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,11 @@
"dependencies": {
"firebase": "^12.4.0",
"rxfire": "^6.2.0",
"@angular-devkit/architect": ">= 0.2100.0 < 0.2200.0",
"@angular-devkit/core": "^21.0.0",
"@angular-devkit/schematics": "^21.0.0",
"@schematics/angular": "^21.0.0",
"jsonc-parser": "^3.0.0",
"tslib": "^2.3.0"
},
"ng-update": {
Expand Down
Loading