Skip to content

zone log verbosity - #3613

Merged
jamesdaniels merged 3 commits into
angular:mainfrom
jamesdaniels:jamesdaniels_zoneLogVerbosity
Jan 16, 2025
Merged

jamesdaniels merged 3 commits into
angular:mainfrom
jamesdaniels:jamesdaniels_zoneLogVerbosity

Conversation

@jamesdaniels

@jamesdaniels jamesdaniels commented Jan 16, 2025 •

Copy link
Copy Markdown
Contributor
  • Add setLogLevel API, default to silent in Zoneless and !devMode, warn otherwise
  • Move AppCheckInstances to @angular/fire/app-check
  • Override verbosity on a bunch of firebase APIs
  • Cleanup

Fixes #3611, #3607, #3605

@jamesdaniels
jamesdaniels merged commit 35e0a98 into angular:main Jan 16, 2025
@jamesdaniels
jamesdaniels deleted the jamesdaniels_zoneLogVerbosity branch January 16, 2025 19:42
armando-navarro added a commit that referenced this pull request Sep 27, 2026
…3770)

AngularFire wrapped beforeAuthStateChanged so that registering the
hook added a pending task, cleared only when the callback first runs.
Firebase runs that callback only on a sign-in or sign-out, so for a
visitor who does neither the app never became stable. Registered on
the server, it failed ng build during route extraction and left
server-rendered requests without a response.

This restores the blockUntilFirst: false override from #3590, which
#3613 dropped without comment while adding log-level overrides next
to it. The callback still runs inside Angular's zone and injection
context, and its returned promise still reaches Firebase, so a
rejection still cancels the sign-in. A call outside an injection
context now logs its per-call warning only at the verbose level, as
onMessage does.

Fixes #3748

docs(auth): scope the beforeAuthStateChanged note to rc.1 and earlier

Merging this change closes #3748, so the section's present-tense note
would point at a closed issue. Also removed the false claim that the
@angular/fire/auth import makes ng build hang: the guide registers the
hook only in the browser, so its own build succeeds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Warning: Firebase API called outside injection context" on non-async functions

1 participant