Skip to content

fix(compat): correct injectors to fix issue with compat API on v19 #3595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesdaniels merged 3 commits into from
Jan 9, 2025
Merged

fix(compat): correct injectors to fix issue with compat API on v19 #3595

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b5f7e5f
fix: run inject in angular injection context
rosostolato Dec 19, 2024
18b61e2
fix: pass injector to pendingUntilEvent pipe
rosostolato Dec 19, 2024
5f830da
TestBed for database test, inject env for Auth and RC
jamesdaniels Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: run inject in angular injection context
  • Loading branch information
@rosostolato
rosostolato committed Dec 26, 2024
commit b5f7e5f1845404f245760efdfb8335d3d13b61ec
5 changes: 3 additions & 2 deletions src/compat/firestore/firestore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ export function associateQuery<T>(collectionRef: CollectionReference<T>, queryFn
export class AngularFirestore {
public readonly firestore: firebase.firestore.Firestore;
public readonly persistenceEnabled$: Observable<boolean>;
private readonly ngZone = inject(NgZone);

/**
* Each Feature of AngularFire has a FirebaseApp injected. This way we
Expand Down Expand Up @@ -197,7 +198,7 @@ export class AngularFirestore {
collectionRef = pathOrRef;
}
const { ref, query } = associateQuery<T>(collectionRef, queryFn);
const refInZone = inject(NgZone).run(() => ref);
const refInZone = this.ngZone.run(() => ref);
return new AngularFirestoreCollection<T>(refInZone, query, this);
}

Expand Down Expand Up @@ -227,7 +228,7 @@ export class AngularFirestore {
} else {
ref = pathOrRef;
}
const refInZone = inject(NgZone).run(() => ref);
const refInZone = this.ngZone.run(() => ref);
return new AngularFirestoreDocument<T>(refInZone, this);
}

Expand Down