Repository navigation
fix: Respect build assets allowOutsideOutdir - #9686
trendzetter wants to merge 1 commit into
Conversation
The old check should be removed so assets are allowed outside the project folder if allowOutsideOutdir is configured. Fixes #9363
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
|
That's not an old check. It's intentional and helps to prevent writing to arbitrary locations on the filesystem. |
|
@clydin: It's checked twice. Once taking into account the optional configuration and the other is not taking into account a valid configuration directive |
|
It's not checked twice; they are two different checks. The first check verifies it is within the |
|
This solution seems to cause an issue |
|
@yuvalbl It's not merged, is it? |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
The old check should be removed so assets are allowed outside the project folder if allowOutsideOutdir is configured.
Fixes #9363