Skip to content

fix: Respect build assets allowOutsideOutdir - #9686

Closed
trendzetter wants to merge 1 commit into
angular:masterfrom
trendzetter:master
Closed

trendzetter wants to merge 1 commit into
angular:masterfrom
trendzetter:master

Conversation

@trendzetter

Copy link
Copy Markdown

The old check should be removed so assets are allowed outside the project folder if allowOutsideOutdir is configured.
Fixes #9363

The old check should be removed so assets are allowed outside the project folder if allowOutsideOutdir is configured.
Fixes #9363
@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@trendzetter

Copy link
Copy Markdown
Author

I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

@clydin

clydin commented Feb 19, 2018 •

Copy link
Copy Markdown
Member

That's not an old check. It's intentional and helps to prevent writing to arbitrary locations on the filesystem.

@trendzetter

Copy link
Copy Markdown
Author

@clydin: It's checked twice. Once taking into account the optional configuration and the other is not taking into account a valid configuration directive

@trendzetter trendzetter changed the title Respect build assets allowOutsideOutdir fix: Respect build assets allowOutsideOutdir Feb 19, 2018
@clydin

clydin commented Feb 19, 2018

Copy link
Copy Markdown
Member

It's not checked twice; they are two different checks. The first check verifies it is within the outputPath for the app. If it is not, then the second check verifies if it is within the project itself. Then it checks if assets are allowed to be written outside the outputPath (but still within the project due to the previous check).

@yuvalbl

yuvalbl commented Apr 23, 2018 •

Copy link
Copy Markdown

This solution seems to cause an issue
See my comment on related item

@trendzetter

Copy link
Copy Markdown
Author

@yuvalbl It's not merged, is it?

@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

allowOutsideOutDir for assets not working again

4 participants