perf(@angular/build): avoid invalidating Angular diagnostic cache on stylesheet change - #34225
Open
alan-agius4 wants to merge 1 commit into
Open
alan-agius4 wants to merge 1 commit into
alan-agius4 wants to merge 1 commit into
Conversation
…stylesheet change Component stylesheets (.css, .scss, .sass, .less) do not impact TypeScript semantic diagnostics or Angular template diagnostics. When a stylesheet dependency changes during watch rebuilds, avoid deleting the component's cached Angular diagnostics or marking the component source file as affected for diagnostics re-collection.
angular-robot
Bot
added
area: performance
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the AotCompilation class in the Angular build tools to prevent style files (such as .css, .scss, .sass, and .less) from invalidating Angular diagnostics and marking source files as affected when component resources are modified. There are no review comments, and we have no additional feedback to provide.
alan-agius4
added
action: review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When any component resource is modified during incremental watch rebuilds, the component's cached Angular diagnostics are invalidated and the component source file is marked as affected for diagnostics collection, even if the modified resource is a stylesheet (.css, .scss, .sass, .less).
What is the new behavior?
Component stylesheets do not affect TypeScript semantic diagnostics or Angular template diagnostics. When a modified component resource is a stylesheet, avoid clearing the component's cached Angular diagnostics and avoid marking the component source file as affected for diagnostics re-collection.
Does this PR introduce a breaking change?