Repository navigation
Conversation
fcdff03 to
807bf0c
Compare
|
I don't know a lot about Dart. CI is red by Dart. |
|
this would be great for universal where the html component should default to none while the application should default to emulated |
|
Conflictions are occurring by changes for code gen. I'll fix these |
53f6c54 to
af9cb75
Compare
ee5f955 to
afd23c1
Compare
|
@laco0416 Could you rebase on the latest code and I will take a look. |
|
@tbosch can you have a look? |
afd23c1 to
dd6aea1
Compare
|
@mhevery Of course! But there are some errors in the offline compiler test. I don't know how to fix it... |
16bc8ad to
d60344f
Compare
|
I think it is blocked by In this scope, no injectors exist. |
There was a problem hiding this comment.
There is no need to introduce a new ViewEncapsulation enum value. We should add a new field to CompilerConfig with the default ViewEncapsulation, read it and set it when calling new CompileTemplateMetadata in directive_normalizer.ts.
There was a problem hiding this comment.
This also needs a test then in the directive_normalizer.ts
d60344f to
9ad5f98
Compare
9ad5f98 to
ba91599
Compare
BREAKING CHANGES: DirectiveNormalizer takes new constructor arguments, `config:CompilerConfig`.
ba91599 to
cbb15ea
Compare
|
@tbosch I've done. please review again! |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
New feature
Default encapsulation is ViewEncapsulation.Emulated. this is not configurable.
Add a DI token;
DEFAULT_VIEW_ENCAPSULATIONto overwrite default encapsulation.No