Conversation
The check that skips encapsulating nested selectors under `::ng-deep` used `.test()` on a global regex, so `lastIndex` carried over to the next rule (or the next stylesheet) when nothing else reset it. A following `::ng-deep` rule could then be missed and its nested selectors scoped.
JoostK
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What is the current behavior?
#69885 skips encapsulating nested selectors when the parent selector contains
::ng-deep. The check uses_shadowDeepSelectors.test(part), but_shadowDeepSelectorsis a module-level regex with thegflag, so a match leaveslastIndexset for the next call.When the matched rule has an empty body, nothing resets it. The next
::ng-deeprule is then tested from the stale offset, is not detected, and its nested selectors get scoped. This also crosses stylesheets: with@angular/compiler@22.2.1,Issue Number: N/A
What is the new behavior?
The check uses a non-global copy of the same pattern, so the result no longer depends on earlier rules.
_shadowDeepSelectorskeeps thegflag for itsreplaceandsplituses.Does this PR introduce a breaking change?
Other information
pnpm bazel test //packages/compiler/test:test— the new spec fails without the fix (.qux[contenta]) and passes with it; the rest of the suite passes.