Conversation
When RouterOutlet.deactivate() is called, the outlet destroys the active component but previously did not unsubscribe from route data. This left the route data subscription and resource binding effects active in the input binder until either the next component was activated on that outlet or the outlet itself was destroyed in ngOnDestroy. This commit eagerly unsubscribes from route data and tears down binding effects in deactivate(), ensuring prompt cleanup when an outlet component is destroyed.
JeanMeche
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
RouterOutlet.deactivate()is called, the outlet destroys the active component but previously did not unsubscribe from route data. This left the route data subscription and resource binding effects (outletEffects) active in the input binder until either the next component was activated on that outlet or the outlet itself was destroyed viangOnDestroy.This commit updates
deactivate()to callinputBinder?.unsubscribeFromRouteData(this), eagerly tearing down the route-data subscription and resource binding effects at destroy time.