Conversation
…ization `CodeMirrorEditor` is a root service, and the code editor component calls its `init()` when it's created and `disable()` when it's destroyed. `disable()` unsubscribes most listeners created by `init()`, but not the ones for the TypeScript VFS worker events and the library typings, which only completed when the root service was destroyed. Each time the editor was created again (e.g. when moving between the playground and a tutorial), another pair of subscriptions was added, so the virtual file system was recreated and the library types were sent to the worker once per previous initialization. Keep these subscriptions and unsubscribe them in `disable()`, like the other listeners.
angular-robot
Bot
added
the
area: docs-infra
MeAkib
force-pushed
the
docs-infra/code-editor-listener-leak
branch
from
September 30, 2026 18:38
7fe4993 to
960a55e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validateHttprequestfunction (they areHttpResourceRequestproperties, nothttpResourceoptions), and fix the invalid object literal in theparseexample.|from a component snippet, fix the "multiple errors" example (a@bis a valid email address for theemail()validator,a@isn't), renamefieldtofieldTreein theFieldContexttable, add the missingsignalimport, use one zod import style, and clarify that dynamic schemas are passed as a function.DisabledReasonexposesfieldTree, notfield.extractValue()to get the whole form value instead of building it manually, and fix the expected output.FormFielddirective by name, release the timer when thedebounceexample is aborted, and add the missingformimport.FormRootand asubmissionaction, so the page no longer reloads on submit.