Conversation
angular-robot
Bot
added
the
area: compiler
JeanMeche
force-pushed
the
img-src
branch
2 times, most recently
from
October 1, 2026 14:42
28e2b7b to
f631ab1
Compare
Member
Author
|
After some testing noticed this is a breaking change at least when the value is Before: Other breaking change: any image passed to |
alan-agius4
approved these changes
Oct 1, 2026
alan-agius4
added
the
requires: TGP
alan-agius4
added
the
action: cleanup
alan-agius4
approved these changes
Oct 1, 2026
alan-agius4
left a comment
alan-agius4
left a comment
Contributor
There was a problem hiding this comment.
Reviewed-for: fw-security
Member
Author
|
(currently looking if we can temporarily workaround this breaking change). |
JeanMeche
force-pushed
the
img-src
branch
4 times, most recently
from
October 1, 2026 16:27
c827694 to
bf205e7
Compare
SkyZeroZx
reviewed
Oct 1, 2026
…ity context. Browsers are already blocking script execution on those attributes.
JeanMeche
removed
action: cleanup
Member
Author
|
I went with a workaround that will also allow me to cleanup g3 once this is merged, plan is to make the work around 3p only until we reach the breaking change window. Unit test will provide the necessary coverage in the mean time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ity context.
Browsers are already blocking script execution on those attributes.