fix(vscode-extension): allow Tailwind-style characters in property binding names - #70526
Merged
Merged
Conversation
angular-robot
Bot
added
the
area: vscode-extension
JeanMeche
reviewed
Sep 14, 2026
JeanMeche
reviewed
Sep 14, 2026
JeanMeche
approved these changes
Sep 14, 2026
JeanMeche
left a comment
JeanMeche
left a comment
Member
There was a problem hiding this comment.
Beside the security concern, lgtm
…nding names The property binding grammar only allowed [-_a-zA-Z0-9.$] in binding names, so Tailwind class bindings such as `[class.hover:flex]`, `[class.!p-4]` or `[class.bg-primary/30]` did not match and fell back to plain HTML attribute highlighting. The compiler is deliberately lenient about the characters between the square brackets of a bound attribute name, so allow `:`, `!`, `/` and `@` in the grammar as well. Also removes the nested quantifier from the binding name regexes ((?:A+|B)* -> (?:A|B)*), which could trigger super-linear backtracking on lines with an unterminated binding. The recognized language is unchanged: the snapshot goldens are identical. Fixes angular#67679
aparzi
force-pushed
the
fix-vscode-tailwind-class-binding
branch
from
September 15, 2026 08:00
65ca272 to
7391e91
Compare
JeanMeche
approved these changes
Sep 20, 2026
JeanMeche
added
action: merge
Contributor
4 of 14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The property binding grammar only allowed [-_a-zA-Z0-9.$] in binding names, so Tailwind class bindings such as
[class.hover:flex],[class.!p-4]or[class.bg-primary/30]did not match and fell back to plain HTML attribute highlighting. The compiler is deliberately lenient about the characters between the square brackets of a bound attribute name, so allow:,!,/and@in the grammar as well.Fixes #67679
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Issue Number: #67679
Does this PR introduce a breaking change?