Skip to content

fix(router): allow parsing url with outlet and children - #64501

Closed
atscott wants to merge 1 commit into
angular:mainfrom
atscott:outletparse
Closed

atscott wants to merge 1 commit into
angular:mainfrom
atscott:outletparse

Conversation

@atscott

@atscott atscott commented Oct 17, 2025

Copy link
Copy Markdown
Contributor

The 'parseParens' method in the URL serializer did not account for segment groups that define an outlet with a path and also have children. This commit adds '(' as a valid character to find after a segment path.

Fixes #58516

The 'parseParens' method in the URL serializer did not account for segment groups that define an outlet with a path and also have children. This commit adds '(' as a valid character to find after a segment path.

Fixes angular#58516
@atscott atscott added the target: patch This PR is targeted for the next patch release label Oct 17, 2025
@ngbot ngbot Bot added this to the Backlog milestone Oct 17, 2025
@atscott
atscott marked this pull request as draft October 17, 2025 17:27
@atscott

atscott commented Oct 17, 2025 •

Copy link
Copy Markdown
Contributor Author

Converting back to draft. It's unclear how the specified URL was constructed in the first place. As far as I can tell, the aux outlet will generate //dock:/(left//1:One;pinned...) rather than //dock:left(1:One;pinned...)

@thePunderWoman
thePunderWoman removed their request for review October 17, 2025 17:39
@atscott

atscott commented Oct 18, 2025

Copy link
Copy Markdown
Contributor Author

superseded by #64507

@atscott atscott closed this Oct 18, 2025
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Nov 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area: router target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid check in router/url_tree/parseParens

1 participant