Conversation
atscott
force-pushed
the
internalerrorhandlerprovider
branch
from
August 26, 2025 19:07
2d6d689 to
5054e2f
Compare
atscott
force-pushed
the
internalerrorhandlerprovider
branch
6 times, most recently
from
August 27, 2025 20:26
6b9e17c to
d2f7f84
Compare
…TestBed error handler The internal error handler in TestBed rethrows errors to prevent them from being silently ignored in tests. Prior to this commit, tests which used `provideZoneChangeDetection` in the providers would override the internal error handler of TestBed and prevent these errors from being rethrown. BREAKING CHANGE: (test only) - Using `provideZoneChangeDetection` in the TestBed providers would previously prevent `TestBed` from rethrowing errors as it should. Errors in the test will now be rethrown, regardless of the usage of `provideZoneChangeDetection`. Tests should be adjusted to prevent or account for these errors. As in previous major versions, this behavior can be disabled with `rethrowApplicationErrors: false` in `configureTestingModule` as a last resort.
atscott
force-pushed
the
internalerrorhandlerprovider
branch
from
August 28, 2025 14:17
d2f7f84 to
6720fb6
Compare
AndrewKushnir
approved these changes
Aug 29, 2025
JeanMeche
removed their request for review
August 31, 2025 10:46
Contributor
|
This PR was merged into the repository. The changes were merged into the following branches:
|
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…TestBed error handler
The internal error handler in TestBed rethrows errors to prevent them from being silently ignored in tests. Prior to this commit, tests which used
provideZoneChangeDetectionin the providers would override the internal error handler of TestBed and prevent these errors from being rethrown.