Skip to content

feat(core): Add migration for zoneless by default. - #63042

Closed
JeanMeche wants to merge 2 commits into
angular:mainfrom
JeanMeche:bootstrap-option-migration
Closed

feat(core): Add migration for zoneless by default.#63042
JeanMeche wants to merge 2 commits into
angular:mainfrom
JeanMeche:bootstrap-option-migration

Conversation

@JeanMeche

@JeanMeche JeanMeche commented Aug 7, 2025

Copy link
Copy Markdown
Member

This migration moves the zone configuration from bootstrapModule/bootstrapApplication to providers. This also include a migration for TestBed.initTestEnvironment

WIP

@angular-robot angular-robot Bot added detected: feature PR contains a feature commit area: core Issues related to the framework runtime labels Aug 7, 2025
@ngbot ngbot Bot added this to the Backlog milestone Aug 7, 2025
@JeanMeche
JeanMeche force-pushed the bootstrap-option-migration branch from 90bc0e6 to 33c9d17 Compare August 7, 2025 01:37
@JeanMeche
JeanMeche requested a review from atscott August 7, 2025 01:38
@JeanMeche
JeanMeche force-pushed the bootstrap-option-migration branch 18 times, most recently from 2460337 to 0a396b7 Compare August 12, 2025 13:23
@JeanMeche JeanMeche mentioned this pull request Aug 12, 2025
Closed
4 of 14 tasks
@JeanMeche
JeanMeche force-pushed the bootstrap-option-migration branch 6 times, most recently from 4181cbd to c7000a1 Compare August 14, 2025 00:00
atscott
atscott reviewed Aug 28, 2025
View reviewed changes
Comment thread packages/core/schematics/migrations/bootstrap-options-migration/migration.ts Outdated
atscott
atscott reviewed Aug 28, 2025
View reviewed changes
Comment thread packages/core/schematics/migrations/bootstrap-options-migration/migration.ts
@JeanMeche
JeanMeche force-pushed the bootstrap-option-migration branch from 8a5efe7 to 59da345 Compare August 28, 2025 21:06
atscott
atscott reviewed Aug 28, 2025
View reviewed changes
Comment thread packages/core/schematics/migrations/bootstrap-options-migration/migration.ts Outdated
@JeanMeche
JeanMeche force-pushed the bootstrap-option-migration branch from 59da345 to e75eb74 Compare August 28, 2025 21:18
@JeanMeche
JeanMeche marked this pull request as ready for review August 29, 2025 02:07
@atscott atscott added the target: major This PR is targeted for the next major release label Aug 29, 2025
@JeanMeche
JeanMeche force-pushed the bootstrap-option-migration branch from 12163c9 to fa13492 Compare September 4, 2025 08:44
@JeanMeche
JeanMeche force-pushed the bootstrap-option-migration branch from 1c8a29c to d34f38f Compare September 11, 2025 22:59
JeanMeche
JeanMeche commented Sep 11, 2025
View reviewed changes
Comment thread packages/core/schematics/migrations/bootstrap-options-migration/migration.ts
const ZONE_CD_PROVIDER = `${PROVIDE_ZONE_CHANGE_DETECTION}()`;

const NoopNgZone = `
// TODO ADD WARNING MESSAGE

@JeanMeche JeanMeche Sep 11, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @AndrewKushnir @jelbourn
You wanted to suggest a specifc error message here

atscott
atscott reviewed Sep 15, 2025
View reviewed changes
Comment thread packages/core/schematics/migrations/bootstrap-options-migration/migration.ts Outdated
@JeanMeche
JeanMeche force-pushed the bootstrap-option-migration branch from 13dd074 to 8e76ca4 Compare September 16, 2025 18:30
@JeanMeche
feat(core): Add migration for zoneless by default.
8ad0d2e 
This commit adds a migration that updates applications enable Zone change detection when Angular is zoneless by default.
@JeanMeche
JeanMeche force-pushed the bootstrap-option-migration branch from 8e76ca4 to 8ad0d2e Compare September 16, 2025 18:30
@JeanMeche

JeanMeche commented Sep 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Marking this one as blocked, until the runtime changes have landed.

@atscott

atscott commented Sep 16, 2025

Copy link
Copy Markdown
Contributor

@JeanMeche Removing the blocked label since this migration can go in first, as long as the other one does eventually land for v21

atscott
atscott reviewed Sep 16, 2025
View reviewed changes
Comment thread packages/core/schematics/migrations/bootstrap-options-migration/migration.spec.ts Outdated
atscott
atscott reviewed Sep 16, 2025
View reviewed changes
Comment thread packages/core/schematics/migrations/bootstrap-options-migration/migration.spec.ts Outdated
@thePunderWoman thePunderWoman added the action: merge The PR is ready for merge by the caretaker label Sep 16, 2025
@thePunderWoman

thePunderWoman commented Sep 16, 2025

Copy link
Copy Markdown
Contributor

This PR was merged into the repository. The changes were merged into the following branches:

wildcardalice pushed a commit to wildcardalice/angular that referenced this pull request Sep 18, 2025
@JeanMeche @wildcardalice
feat(core): Add migration for zoneless by default. (angular#63042)
255120c 
This commit adds a migration that updates applications enable Zone change detection when Angular is zoneless by default.

PR Close angular#63042
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Oct 17, 2025

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Oct 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@atscott atscott atscott approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime detected: feature PR contains a feature commit target: major This PR is targeted for the next major release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@JeanMeche @atscott @thePunderWoman