Skip to content

fix(compiler-cli): resolve deprecation warning #48812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoostK wants to merge 1 commit into from
Closed

fix(compiler-cli): resolve deprecation warning #48812

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/compiler-cli/src/ngtsc/typecheck/src/type_constructor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@ export function generateInlineTypeCtor(

// Create the type constructor method declaration.
return ts.factory.createMethodDeclaration(

@crisbeto crisbeto Jan 23, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know when this became deprecated? If it was in 4.8, we would have to support both signatures for a while due to g3.

@JoostK JoostK Jan 23, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, it was deprecated in microsoft/TypeScript#49089 which shipped in 4.8, but the deprecation only started to report a warning in 4.9 (per this line).

The same change was recently made to a different usage of createMethodDeclaration in #48652, so this one should also be fine in g3.

/* decorators */ undefined,
/* modifiers */[ts.factory.createModifier(ts.SyntaxKind.StaticKeyword)],
/* asteriskToken */ undefined,
/* name */ meta.fnName,
Expand Down