Skip to content

fix(language-service): ship /api entry-point #48670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devversion wants to merge 1 commit into from
Closed

fix(language-service): ship /api entry-point #48670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(language-service): ship /api entry-point 
The `/api` entry-point was accidentally dropped when we switched the
compilation in the repo to full ESM- thinking the entry-point is not
needed externally.

We re-add it because the VSCode repo extension relies on it for checking
whether `ts.LanguageService` is an Angular one.
  • Loading branch information
@devversion
devversion committed Jan 9, 2023
commit 22b1dd22b13c44b7ce3e5098f8023a2917e9a32d
17 changes: 14 additions & 3 deletions packages/language-service/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,19 @@ esbuild(
deps = [":factory_lib"],
)

esbuild(
name = "api_bundle",
entry_point = ":api.ts",
format = "cjs",
deps = [":api"],
)

extract_types(
name = "factory_types",
deps = [":factory_lib"],
name = "types",
deps = [
":api",
":factory_lib",
],
)

pkg_npm(
Expand All @@ -55,8 +65,9 @@ pkg_npm(
"//integration:__subpackages__",
],
deps = [
":api_bundle",
":factory_bundle",
":factory_types",
":types",
"//packages/language-service/bundles:language-service.js",
],
)
10 changes: 10 additions & 0 deletions packages/language-service/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,16 @@
"engines": {
"node": "^14.20.0 || ^16.13.0 || >=18.10.0"
},
"exports": {
".": {
"types": "./index.d.ts",
"default": "./index.js"
},
"./api": {
"types": "./api.d.ts",
"default": "./api_bundle.js"
}
},
"repository": {
"type": "git",
"url": "https://github.com/angular/angular.git",
Expand Down