Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(compiler-cli): update
@babel/coredependency and lock version #48634New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
fix(compiler-cli): update
@babel/coredependency and lock version #48634Changes from all commits
591997dFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
@babel/coredependency and lock versionSimilar to how the `@babel/core` dependency is managed for the localize NPM package, the version should be locked. Also the version should correspond to the version we install for building & testing. Currently the Babel version allowed by the compiler-cli may not work given the ESM -> CJS interop. causing errors like: ``` import { types as t } from "@babel/core"; ^^^^^ SyntaxError: Named export 'types' not found. The requested module '@babel/core' is a CommonJS module, which may not support all module.exports as named exports. CommonJS modules can always be imported via the default export, for example using: import pkg from '@babel/core'; const { types: t } = pkg; ``` We can only be confident about the interop if we know the version installed- is the one we test.Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing