Repository navigation
Conversation
atscott
added
state: blocked
target: minor
angular-robot
Bot
added
detected: deprecation
atscott
force-pushed
the
deprecateNavigatedWrites
branch
from
November 22, 2022 20:28
8973139 to
e434038
Compare
atscott
marked this pull request as ready for review
November 22, 2022 20:28
pullapprove
Bot
requested review from
AndrewKushnir,
dylhunn and
pkozlowski-opensource
November 22, 2022 20:28
atscott
force-pushed
the
deprecateNavigatedWrites
branch
from
November 22, 2022 20:53
e434038 to
59f575f
Compare
The router.navigated property is meant to be read-only externally. Writing to it is simply a workaround for APIs that had previously been missing in the Router DEPRECATED: The router.navigated property is meant to be read-only externally. Writing to it is simply a workaround for APIs that had previously been missing in the Router. To force reloads, pass `onSameUrlNavigation: 'reload'` in the options of `Router.navigate`.
atscott
force-pushed
the
deprecateNavigatedWrites
branch
from
November 22, 2022 21:02
59f575f to
1c198d4
Compare
AndrewKushnir
approved these changes
Nov 22, 2022
dylhunn
approved these changes
Nov 23, 2022
dylhunn
left a comment
dylhunn
left a comment
Contributor
There was a problem hiding this comment.
reviewed-for: public-api
jessicajaniuk
approved these changes
Nov 23, 2022
jessicajaniuk
left a comment
jessicajaniuk
left a comment
Contributor
There was a problem hiding this comment.
reviewed-for: public-api
pkozlowski-opensource
added
the
action: merge
bob-watson
added
the
action: cleanup
Contributor
Author
|
Closing for now. The |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The router.navigated property is meant to be read-only externally. Writing to it is simply a workaround for APIs that had previously been missing in the Router
DEPRECATED:
The router.navigated property is meant to be read-only externally. Writing to it is simply a workaround for APIs that had previously been missing in the Router. To force reloads, pass
onSameUrlNavigation: 'reload'in the options ofRouter.navigate.