Skip to content

refactor(compiler): some small compiler refactorings - #43129

Closed
petebacondarwin wants to merge 7 commits into
angular:masterfrom
petebacondarwin:compiler-refactorings
Closed

refactor(compiler): some small compiler refactorings#43129
petebacondarwin wants to merge 7 commits into
angular:masterfrom
petebacondarwin:compiler-refactorings

Conversation

@petebacondarwin

@petebacondarwin petebacondarwin commented Aug 12, 2021

Copy link
Copy Markdown
Contributor

These commits were extracted from the reverted #42062 PR since they do not change any behaviour.
This PR let's us land those commits now, and will make the reworking of #42062 simpler.

@petebacondarwin
refactor(ngcc): remove unused import
35b4a94 
This import is not used in the file, so can be removed.
@petebacondarwin
test(compiler-cli): clarify source-map expectations in compliance tests
7b1048f 
The compliance tests can check source-map segments against expectations
encoded into the expectation files. Previously, the encoding of the expected
segment was only delimited by whitespace, but this made it difficult to identify
segments that started or ended with whitespace.

Now these segment expectations are wrapped in double-quotes which makes
it easier to read and understand the expectation files.
@petebacondarwin
refactor(compiler): remove cyclic dependencies
8a4743f 
This commit removes 9 cycles in the dependency graph of the compiler code.
@petebacondarwin
refactor(compiler): share isQuote() via chars.ts
894046c 
This function is general purpose and by moving it into the
`chars.ts` file along with similar helpers, it can be reused
in the lexer, for instance.
@petebacondarwin
refactor(compiler): use === rather than == in the ml_parser
16e8585 
This is a simple tidy up commit to move to the more specific `===`
comparison operator in the HTML lexer/parser.
@petebacondarwin
test(compiler): check that the parser supports prematurely terminated…
fe95893 
… interpolations

Such interpolations turned up during internal testing at Google, so this
commit adds a test to prevent regressions.
@petebacondarwin
test(compiler): add a test for parsing multiline expressions in attri…
3ea35df 
…butes

This tests a scenario that was failing in an internal project.
@pullapprove
pullapprove Bot requested a review from JoostK August 12, 2021 10:50
@petebacondarwin
petebacondarwin requested review from AndrewKushnir and removed request for JoostK August 12, 2021 10:50
@google-cla google-cla Bot added the cla: yes label Aug 12, 2021
@petebacondarwin petebacondarwin added action: presubmit The PR is in need of a google3 presubmit action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Aug 12, 2021
@petebacondarwin petebacondarwin mentioned this pull request Aug 12, 2021
Closed
@AndrewKushnir AndrewKushnir added the area: compiler Issues related to `ngc`, Angular's template compiler label Aug 12, 2021
@ngbot ngbot Bot added this to the Backlog milestone Aug 12, 2021
@AndrewKushnir

AndrewKushnir commented Aug 13, 2021

Copy link
Copy Markdown
Contributor

Presubmit.

@AndrewKushnir

AndrewKushnir commented Aug 16, 2021

Copy link
Copy Markdown
Contributor

Global Presubmit.

@AndrewKushnir AndrewKushnir removed the action: presubmit The PR is in need of a google3 presubmit label Aug 16, 2021
@AndrewKushnir

AndrewKushnir commented Aug 16, 2021

Copy link
Copy Markdown
Contributor

@petebacondarwin FYI presubmits went well + I also verified that there are no changes in the extracted message IDs for the app that was affected previously by #42062.

@AndrewKushnir
AndrewKushnir removed their request for review August 16, 2021 19:48
@AndrewKushnir AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Aug 16, 2021
@AndrewKushnir

AndrewKushnir commented Aug 16, 2021

Copy link
Copy Markdown
Contributor

Note to Caretaker: since this is a part of the PR that was reverted earlier (due to g3 issues), please sync this PR into g3 as a separate change to minimize the risks and simplify the rollback if needed.

@petebacondarwin petebacondarwin added the action: merge The PR is ready for merge by the caretaker label Aug 16, 2021
dylhunn pushed a commit that referenced this pull request Aug 16, 2021
@petebacondarwin @dylhunn
refactor(ngcc): remove unused import (#43129)
c792dd7 
This import is not used in the file, so can be removed.

PR Close #43129
dylhunn pushed a commit that referenced this pull request Aug 16, 2021
@petebacondarwin @dylhunn
test(compiler-cli): clarify source-map expectations in compliance tes…
616133c 
…ts (#43129)

The compliance tests can check source-map segments against expectations
encoded into the expectation files. Previously, the encoding of the expected
segment was only delimited by whitespace, but this made it difficult to identify
segments that started or ended with whitespace.

Now these segment expectations are wrapped in double-quotes which makes
it easier to read and understand the expectation files.

PR Close #43129
dylhunn pushed a commit that referenced this pull request Aug 16, 2021
@petebacondarwin @dylhunn
refactor(compiler): remove cyclic dependencies (#43129)
92fa1a6 
This commit removes 9 cycles in the dependency graph of the compiler code.

PR Close #43129
dylhunn pushed a commit that referenced this pull request Aug 16, 2021
@petebacondarwin @dylhunn
refactor(compiler): share isQuote() via chars.ts (#43129)
510931a 
This function is general purpose and by moving it into the
`chars.ts` file along with similar helpers, it can be reused
in the lexer, for instance.

PR Close #43129
dylhunn pushed a commit that referenced this pull request Aug 16, 2021
@petebacondarwin @dylhunn
refactor(compiler): use === rather than == in the ml_parser (#43129)
a701c10 
This is a simple tidy up commit to move to the more specific `===`
comparison operator in the HTML lexer/parser.

PR Close #43129
dylhunn pushed a commit that referenced this pull request Aug 16, 2021
@petebacondarwin @dylhunn
test(compiler): check that the parser supports prematurely terminated…
1e811df 
… interpolations (#43129)

Such interpolations turned up during internal testing at Google, so this
commit adds a test to prevent regressions.

PR Close #43129
dylhunn pushed a commit that referenced this pull request Aug 16, 2021
@petebacondarwin @dylhunn
test(compiler): add a test for parsing multiline expressions in attri…
cd10a4c 
…butes (#43129)

This tests a scenario that was failing in an internal project.

PR Close #43129
@dylhunn dylhunn closed this in c5250ae Aug 16, 2021
dylhunn pushed a commit that referenced this pull request Aug 16, 2021
@petebacondarwin @dylhunn
test(compiler-cli): clarify source-map expectations in compliance tes…
9e18b65 
…ts (#43129)

The compliance tests can check source-map segments against expectations
encoded into the expectation files. Previously, the encoding of the expected
segment was only delimited by whitespace, but this made it difficult to identify
segments that started or ended with whitespace.

Now these segment expectations are wrapped in double-quotes which makes
it easier to read and understand the expectation files.

PR Close #43129
dylhunn pushed a commit that referenced this pull request Aug 16, 2021
@petebacondarwin @dylhunn
refactor(compiler): remove cyclic dependencies (#43129)
c32bfe5 
This commit removes 9 cycles in the dependency graph of the compiler code.

PR Close #43129
dylhunn pushed a commit that referenced this pull request Aug 16, 2021
@petebacondarwin @dylhunn
refactor(compiler): share isQuote() via chars.ts (#43129)
0d71bc6 
This function is general purpose and by moving it into the
`chars.ts` file along with similar helpers, it can be reused
in the lexer, for instance.

PR Close #43129
dylhunn pushed a commit that referenced this pull request Aug 16, 2021
@petebacondarwin @dylhunn
refactor(compiler): use === rather than == in the ml_parser (#43129)
0f56b03 
This is a simple tidy up commit to move to the more specific `===`
comparison operator in the HTML lexer/parser.

PR Close #43129
dylhunn pushed a commit that referenced this pull request Aug 16, 2021
@petebacondarwin @dylhunn
test(compiler): check that the parser supports prematurely terminated…
a6fab37 
… interpolations (#43129)

Such interpolations turned up during internal testing at Google, so this
commit adds a test to prevent regressions.

PR Close #43129
dylhunn pushed a commit that referenced this pull request Aug 16, 2021
@petebacondarwin @dylhunn
test(compiler): add a test for parsing multiline expressions in attri…
66f1962 
…butes (#43129)

This tests a scenario that was failing in an internal project.

PR Close #43129
@petebacondarwin
petebacondarwin deleted the compiler-refactorings branch August 17, 2021 15:09
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 17, 2021

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JoostK JoostK JoostK approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@petebacondarwin @AndrewKushnir @JoostK