Skip to content

revert: refactor(compiler): support interpolation and encoded entities when lexing markup - #43033

Closed
atscott wants to merge 14 commits into
angular:masterfrom
atscott:revertextractionissue
Closed

revert: refactor(compiler): support interpolation and encoded entities when lexing markup#43033
atscott wants to merge 14 commits into
angular:masterfrom
atscott:revertextractionissue

Conversation

@atscott

@atscott atscott commented Aug 3, 2021

Copy link
Copy Markdown
Contributor

Reverts #42062 due to it causing new messages for &ngsp; and &. This triggers the need for re-trasnlation and could result in untranslated messages in production.

atscott added 14 commits August 3, 2021 14:48
@atscott
Revert "test(compiler): add a test for parsing multiline expressions …
f3a88b8 
…in attributes (angular#42062)"

This reverts commit fe12651.
@atscott
Revert "refactor(compiler): use === rather than == in the ml_pars…
fa7c44a 
…er (angular#42062)"

This reverts commit 28b0c45.
@atscott
Revert "test(compiler): check that the parser supports prematurely te…
d4a9b85 
…rminated interpolations (angular#42062)"

This reverts commit 11ebe21.
@atscott
Revert "refactor(compiler): define interfaces for each lexer token (a…
37ff7f3 
…ngular#42062)"

This reverts commit 9b3d4f5.
@atscott
Revert "fix(compiler): include leading whitespace in source-spans of …
9d039e1 
…i18n messages (angular#42062)"

This reverts commit f08516d.
@atscott
Revert "test(compiler): check fullStart source-span (angular#42062)"
7260758 
This reverts commit 973f9b8.
@atscott
Revert "refactor(compiler): expose token parts in Text nodes (angular…
0257faf 
…#42062)"

This reverts commit 8a54896.
@atscott
Revert "refactor(compiler): support encoded entity tokens when lexing…
b65e0f5 
… markup (angular#42062)"

This reverts commit 942b24d.
@atscott
Revert "refactor(compiler): support interpolation tokens when lexing …
a743870 
…attribute values (angular#42062)"

This reverts commit c516e25.
@atscott
Revert "refactor(compiler): share isQuote() via chars.ts (angular…
91ab82e 
…#42062)"

This reverts commit 3d3b69f.
@atscott
Revert "refactor(compiler): support interpolation tokens when lexing …
a72ae0f 
…markup (angular#42062)"

This reverts commit c8a46bf.
@atscott
Revert "refactor(compiler): remove cyclic dependencies (angular#42062)"
b1382a8 
This reverts commit 7585519.
@atscott
Revert "test(compiler-cli): clarify source-map expectations in compli…
538a2e0 
…ance tests (angular#42062)"

This reverts commit 29f9888.
@atscott
Revert "refactor(ngcc): remove unused import (angular#42062)"
dfb875a 
This reverts commit 42265cc.
@atscott atscott added the target: patch This PR is targeted for the next patch release label Aug 3, 2021
@google-cla google-cla Bot added the cla: yes label Aug 3, 2021
@atscott

atscott commented Aug 3, 2021

Copy link
Copy Markdown
Contributor Author

presubmit

@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Aug 3, 2021
@ngbot

ngbot Bot commented Aug 3, 2021

Copy link
Copy Markdown

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "google3" is failing
    pending status "pullapprove" is pending
    pending 2 pending code reviews

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@atscott atscott closed this in f85b5f9 Aug 3, 2021
atscott added a commit that referenced this pull request Aug 3, 2021
@atscott
Revert "refactor(compiler): use === rather than == in the ml_pars…
28651eb 
…er (#42062)" (#43033)

This reverts commit 28b0c45.

PR Close #43033
atscott added a commit that referenced this pull request Aug 3, 2021
@atscott
Revert "test(compiler): check that the parser supports prematurely te…
fac6ea5 
…rminated interpolations (#42062)" (#43033)

This reverts commit 11ebe21.

PR Close #43033
atscott added a commit that referenced this pull request Aug 3, 2021
@atscott
Revert "refactor(compiler): define interfaces for each lexer token (#…
8b6f7ac 
…42062)" (#43033)

This reverts commit 9b3d4f5.

PR Close #43033
atscott added a commit that referenced this pull request Aug 3, 2021
@atscott
Revert "fix(compiler): include leading whitespace in source-spans of …
dd82bbf 
…i18n messages (#42062)" (#43033)

This reverts commit f08516d.

PR Close #43033
atscott added a commit that referenced this pull request Aug 3, 2021
@atscott
Revert "test(compiler): check fullStart source-span (#42062)" (#43033)
6f05dd8 
This reverts commit 973f9b8.

PR Close #43033
atscott added a commit that referenced this pull request Aug 3, 2021
@atscott
Revert "refactor(compiler): expose token parts in Text nodes (#42062)" (
ea5ed4e 
#43033)

This reverts commit 8a54896.

PR Close #43033
atscott added a commit that referenced this pull request Aug 3, 2021
@atscott
Revert "refactor(compiler): support encoded entity tokens when lexing…
8d8ab47 
… markup (#42062)" (#43033)

This reverts commit 942b24d.

PR Close #43033
atscott added a commit that referenced this pull request Aug 3, 2021
@atscott
Revert "refactor(compiler): support interpolation tokens when lexing …
07846e5 
…attribute values (#42062)" (#43033)

This reverts commit c516e25.

PR Close #43033
atscott added a commit that referenced this pull request Aug 3, 2021
@atscott
Revert "refactor(compiler): share isQuote() via chars.ts (#42062)" (
6f80c55 
#43033)

This reverts commit 3d3b69f.

PR Close #43033
atscott added a commit that referenced this pull request Aug 3, 2021
@atscott
Revert "refactor(compiler): support interpolation tokens when lexing …
6a59e6b 
…markup (#42062)" (#43033)

This reverts commit c8a46bf.

PR Close #43033
atscott added a commit that referenced this pull request Aug 3, 2021
@atscott
Revert "refactor(compiler): remove cyclic dependencies (#42062)" (#43033
4997a3f 
)

This reverts commit 7585519.

PR Close #43033
atscott added a commit that referenced this pull request Aug 3, 2021
@atscott
Revert "test(compiler-cli): clarify source-map expectations in compli…
ae98b24 
…ance tests (#42062)" (#43033)

This reverts commit 29f9888.

PR Close #43033
atscott added a commit that referenced this pull request Aug 3, 2021
@atscott
Revert "refactor(ngcc): remove unused import (#42062)" (#43033)
3a9ce61 
This reverts commit 42265cc.

PR Close #43033
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 3, 2021

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes
@gkalpak gkalpak Awaiting requested review from gkalpak
@petebacondarwin petebacondarwin Awaiting requested review from petebacondarwin

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@atscott @AndrewKushnir