Skip to content

refactor(compiler): support interpolation and encoded entities when lexing markup #42062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
petebacondarwin wants to merge 14 commits into from
Closed

refactor(compiler): support interpolation and encoded entities when lexing markup #42062

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ddde445
refactor(ngcc): remove unused import
petebacondarwin Jun 30, 2021
a60a265
test(compiler-cli): clarify source-map expectations in compliance tests
petebacondarwin May 20, 2021
e8ff091
refactor(compiler): remove cyclic dependencies
petebacondarwin May 19, 2021
e7f9437
refactor(compiler): support interpolation tokens when lexing markup
petebacondarwin May 11, 2021
49462aa
refactor(compiler): share `isQuote()` via `chars.ts`
petebacondarwin May 12, 2021
37d6155
refactor(compiler): support interpolation tokens when lexing attribut…
petebacondarwin May 13, 2021
c2217f5
refactor(compiler): support encoded entity tokens when lexing markup
petebacondarwin May 14, 2021
e95d34b
refactor(compiler): expose token parts in Text nodes
petebacondarwin May 15, 2021
067b6d7
test(compiler): check `fullStart` source-span
petebacondarwin May 20, 2021
80363b1
fix(compiler): include leading whitespace in source-spans of i18n mes…
petebacondarwin Jun 8, 2021
17054fb
refactor(compiler): define interfaces for each lexer token
petebacondarwin Jun 12, 2021
0384fa4
test(compiler): check that the parser supports prematurely terminated…
petebacondarwin Jun 17, 2021
a1e9d44
refactor(compiler): use `===` rather than `==` in the ml_parser
petebacondarwin Jul 1, 2021
af8141d
test(compiler): add a test for parsing multiline expressions in attri…
petebacondarwin Jul 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test(compiler): check that the parser supports prematurely terminated… 
… interpolations

Such interpolations turned up during internal testing at Google, so this
commit adds a test to prevent regressions.
  • Loading branch information
@petebacondarwin
petebacondarwin committed Jul 31, 2021
commit 0384fa4e533d9f7d0c1357267e4862f795d35b0f
27 changes: 27 additions & 0 deletions packages/compiler/test/ml_parser/html_parser_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,23 @@ import {humanizeDom, humanizeDomSourceSpans, humanizeLineColumn, humanizeNodes}
]);
expect(parsed.errors).toEqual([]);
});

it('should treat prematurely terminated interpolation as text', () => {
const {errors, rootNodes} =
parser.parse('<div><span>x {{ expr }<!---->} y</span><div></div></div>', 'TestComp');
expect(humanizeNodes(rootNodes, true)).toEqual([
[
html.Element, 'div', 0, '<div><span>x {{ expr }<!---->} y</span><div></div></div>',
'<div>', '</div>'
],
[html.Element, 'span', 1, '<span>x {{ expr }<!---->} y</span>', '<span>', '</span>'],
[html.Text, 'x {{ expr }', 2, ['x '], ['{{', ' expr }'], [''], 'x {{ expr }'],
[html.Comment, '', 2, '<!--'],
[html.Text, '} y', 2, ['} y'], '} y'],
[html.Element, 'div', 1, '<div></div>', '<div>', '</div>'],
]);
expect(errors).toEqual([]);
});
});

describe('attributes', () => {
Expand Down Expand Up @@ -318,6 +335,16 @@ import {humanizeDom, humanizeDomSourceSpans, humanizeLineColumn, humanizeNodes}
[html.Attribute, ':xlink:href', 'Port', ['Port']],
]);
});

it('should support a prematurely terminated interpolation in attribute', () => {
const {errors, rootNodes} = parser.parse('<div p="{{ abc"><span></span>', 'TestComp');
expect(humanizeNodes(rootNodes, true)).toEqual([
[html.Element, 'div', 0, '<div p="{{ abc">', '<div p="{{ abc">', null],
[html.Attribute, 'p', '{{ abc', [''], ['{{', ' abc'], [''], 'p="{{ abc"'],
[html.Element, 'span', 1, '<span></span>', '<span>', '</span>'],
]);
expect(humanizeErrors(errors)).toEqual([]);
});
});

describe('comments', () => {
Expand Down