Skip to content

ci: Add docs label to guide/example changes on aio - #40273

Closed
atscott wants to merge 2 commits into
angular:masterfrom
atscott:docslabel
Closed

atscott wants to merge 2 commits into
angular:masterfrom
atscott:docslabel

Conversation

@atscott

@atscott atscott commented Dec 28, 2020

Copy link
Copy Markdown
Contributor

The current configuration does not capture all possibilities for the docs label.
This change adds a group which applies the docs label for anything any changes
to aio guides or examples.

@atscott atscott added the target: patch This PR is targeted for the next patch release label Dec 28, 2020
@google-cla google-cla Bot added the cla: yes label Dec 28, 2020
@pullapprove pullapprove Bot added the area: build & ci Related the build and CI infrastructure of the project label Dec 28, 2020
@ngbot ngbot Bot added this to the Backlog milestone Dec 28, 2020
@gkalpak

gkalpak commented Dec 29, 2020

Copy link
Copy Markdown
Member

I believe this should be covered by #40225.

@gkalpak

gkalpak commented Dec 29, 2020

Copy link
Copy Markdown
Member

But if this config works (i.e. if you can have groups that add labels but do not affect reviewing, this might be a better approach than #40225 (easier to maintain) 馃槄

@gkalpak gkalpak mentioned this pull request Dec 29, 2020
3 of 14 tasks
The current configuration does not capture all possibilities for the docs label.
This change adds a group which applies the docs label for anything any changes
to aio guides or examples.
Comment thread .pullapprove.yml Outdated
Comment thread .pullapprove.yml Outdated
@atscott

atscott commented Jan 6, 2021

Copy link
Copy Markdown
Contributor Author

Closing, see discussion in #40225

@atscott atscott closed this Jan 6, 2021
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Feb 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants