Skip to content

fix(core): set ngDevMode to false when calling enableProdMode() #40159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kyliau wants to merge 2 commits into from
Closed

fix(core): set ngDevMode to false when calling enableProdMode() #40159

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e7084f
fix(core): set `ngDevMode` to `false` when calling `enableProdMode()`
alan-agius4 Dec 15, 2020
630eedd
build: upgrade typescript (dev dep) in zone.js to 3.8.3
kyliau Dec 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(core): set ngDevMode to false when calling enableProdMode() 
The `ngDevMode` description also mentions that calling `enableProdMode` will set this the value to `false`.
https://github.com/angular/angular/blob/4610093c87975b6355f31a9c849351129908783a/packages/core/src/util/ng_dev_mode.ts#L22 which is currently not the case.
  • Loading branch information
@alan-agius4 @kyliau
alan-agius4 authored and kyliau committed Dec 16, 2020
commit 2e7084f43c58a0da033576883da21a5303be25ed
9 changes: 9 additions & 0 deletions packages/core/src/util/is_dev_mode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
* found in the LICENSE file at https://angular.io/license
*/

import {global} from './global';

/**
* This file is used to control if the default rendering pipeline should be `ViewEngine` or `Ivy`.
*
Expand Down Expand Up @@ -44,5 +46,12 @@ export function enableProdMode(): void {
if (_runModeLocked) {
throw new Error('Cannot enable prod mode after platform setup.');
}

// The below check is there so when ngDevMode is set via terser
// `global['ngDevMode'] = false;` is also dropped.
if (typeof ngDevMode === undefined || !!ngDevMode) {
global['ngDevMode'] = false;
}

_devMode = false;
}