Skip to content

perf(core): use ngDevMode to tree-shake checkNoChanges #39964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arturovt wants to merge 8 commits into from
Closed

perf(core): use ngDevMode to tree-shake checkNoChanges #39964

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
951a13e
perf(core): use `ngDevMode` to tree-shake `checkNoChanges`
arturovt Dec 3, 2020
4c4f486
perf(common): use `ngDevMode` to tree-shake warnings
arturovt Dec 4, 2020
f0c7f5d
perf(animations): use `ngDevMode` to tree-shake warning
arturovt Dec 4, 2020
d2df865
perf(forms): use `ngDevMode` to tree-shake `_ngModelWarning`
arturovt Dec 4, 2020
264f1a4
fixup! perf(core): use `ngDevMode` to tree-shake `checkNoChanges`
arturovt Dec 4, 2020
2d56c2b
fixup! perf(core): use `ngDevMode` to tree-shake `checkNoChanges`
arturovt Dec 4, 2020
2c6a6f1
fixup! perf(core): use `ngDevMode` to tree-shake `checkNoChanges`
arturovt Dec 4, 2020
fd71829
fixup! perf(core): use `ngDevMode` to tree-shake `checkNoChanges`
arturovt Dec 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! perf(core): use ngDevMode to tree-shake checkNoChanges
  • Loading branch information
@arturovt
arturovt committed Dec 4, 2020
commit 2d56c2b23dcce9127d12e6678da1a2076218317f
2 changes: 2 additions & 0 deletions packages/core/src/application_ref.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -761,6 +761,8 @@ export class ApplicationRef {
for (let view of this._views) {
view.detectChanges();
}
// Note that we have still left the `isDevMode()` condition in order to avoid
// creating a breaking change for projects that still use the View Engine.
if ((typeof ngDevMode === 'undefined' || ngDevMode) && isDevMode()) {
for (let view of this._views) {
view.checkNoChanges();
Expand Down