Repository navigation
Conversation
atscott
added
action: review
petebacondarwin
suggested changes
Nov 17, 2020
AndrewKushnir
approved these changes
Nov 25, 2020
AndrewKushnir
left a comment
AndrewKushnir
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍 Just a couple comments to add some notes on undefined vs null values.
Reviewed-for: public-api
Allow configuration of `relativeTo` in the `routerLink` directive. This is related to the clearing of auxiliary routes, where you need to use `relativeTo: route.parent` in order to clear it from the activated auxiliary component itself. This is because `relativeTo: route` will consume the segment that we're trying to clear, so there is really no way to do this with routerLink at the moment. Related issue: angular#13523 Related (internal link): https://yaqs.corp.google.com/eng/q/5999443644645376
petebacondarwin
approved these changes
Nov 25, 2020
petebacondarwin
approved these changes
Nov 25, 2020
petebacondarwin
left a comment
petebacondarwin
left a comment
Contributor
There was a problem hiding this comment.
Reviewed-for: public-api
jelbourn
reviewed
Nov 25, 2020
jelbourn
left a comment
jelbourn
left a comment
Contributor
There was a problem hiding this comment.
We should add docs for this in the same PR
jelbourn
approved these changes
Dec 7, 2020
jelbourn
left a comment
jelbourn
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Reviewed-for: public-api
atscott
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow configuration of
relativeToin therouterLinkdirective. Thisis related to the clearing of auxiliary routes, where you need to use
relativeTo: route.parentin order to clear it from the activatedauxiliary component itself. This is because
relativeTo: routewillconsume the segment that we're trying to clear, so there is really no
way to do this with routerLink at the moment.
Related issue: #13523
Related (internal link): https://yaqs.corp.google.com/eng/q/5999443644645376