Repository navigation
Conversation
|
You can preview 278fe57 at https://pr20947-278fe57.ngbuilds.io/. |
vicb
approved these changes
Dec 12, 2017
Contributor
|
from @chuckjaz: travis failing is not related to the PR |
Due to an overly agressive assert the compiler would generate an internal error when referencing an enum declared in namspace. Fixes angular#18170
|
You can preview a90a343 at https://pr20947-a90a343.ngbuilds.io/. |
jasonaden
pushed a commit
that referenced
this pull request
Dec 13, 2017
Contributor
|
Any chance to get it back port to v4? |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to an overly agressive assert the compiler would generate
an internal error when referencing an enum declared in
namspace.
Fixes #18170
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #18170
What is the new behavior?
The assert is removed and change to remove the members before loading the summary for a enum reference.
Does this PR introduce a breaking change?
Other information