Skip to content

fix(compiler): do not consider a reference with members as a reference - #19454

Merged
vicb merged 1 commit into
angular:masterfrom
chuckjaz:issue18170
Sep 28, 2017
Merged

vicb merged 1 commit into
angular:masterfrom
chuckjaz:issue18170

Conversation

@chuckjaz

Copy link
Copy Markdown
Contributor

Fixes: #18170

PR Type

What kind of change does this PR introduce?

[x] Bugfix

What is the current behavior?

In a case described in #18170 the change to allow references in place of full evaluation treated a member selection reference as a normal reference which is not supported by the compiler.

Issue Number: #18170

What is the new behavior?

Symbols with member access are evaluated aggressively instead of treated as a reference the compiler can generate.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

馃摑 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@chuckjaz chuckjaz added cla: yes target: patch This PR is targeted for the next patch release and removed cla: no labels Sep 27, 2017
@mary-poppins

Copy link
Copy Markdown

You can preview e94d74a at https://pr19454-e94d74a.ngbuilds.io/.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo becuase

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo ?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove useless name ?

@vicb vicb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few nits

@mary-poppins

Copy link
Copy Markdown

You can preview 1f50ffe at https://pr19454-1f50ffe.ngbuilds.io/.

@mary-poppins

Copy link
Copy Markdown

You can preview c81b1c2 at https://pr19454-c81b1c2.ngbuilds.io/.

@chuckjaz chuckjaz added the action: merge The PR is ready for merge by the caretaker label Sep 28, 2017
@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ERROR in Illegal state: symbol without members expected when using AOT in 4.3.0

4 participants