Skip to content

make INTERPOLATE_REGEXP customizable #7417 #8865

Closed

Description

@vicb

INTERPOLATE_REGEXP was made configurable in #7417

I'm not sure if this will work well with i18n

/cc @laco0416

Activity

  1. mhevery commented on May 26, 2016

    @mhevery
    Contributor

    A better design would be to pass in start/end delimiter rather than a generic RegExp.

  2. lacolaco commented on May 27, 2016

    @lacolaco
    Contributor

    I agreed. I think CompilerConfig#interpolateSymbols is better
    2016/05/27 5:43 "Miško Hevery" notifications@github.com:

    A better design would be to pass in start/end delimiter rather than a
    generic RegExp.

    —
    You are receiving this because you were mentioned.
    Reply to this email directly or view it on GitHub
    #8865 (comment)

  3. lacolaco commented on May 27, 2016

    @lacolaco
    Contributor

    Do we need the following symbol settings?

    • interpolationStart/End
    • i18nStart/End
      2016/05/27 9:13 "Suguru Inatomi" laco0416@gmail.com:

    I agreed. I think CompilerConfig#interpolateSymbols is better
    2016/05/27 5:43 "Miško Hevery" notifications@github.com:

    A better design would be to pass in start/end delimiter rather than a
    generic RegExp.

    —
    You are receiving this because you were mentioned.
    Reply to this email directly or view it on GitHub
    #8865 (comment)

  4. pkozlowski-opensource commented on Jun 10, 2016

    @pkozlowski-opensource
    Member

    This got fixed in master via c3fafa0

  5. angular-automatic-lock-bot commented on Sep 8, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  6. locked and limited conversation to collaborators on Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: i18nIssues related to localization and internationalization

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions