Skip to content

Fix regression in dynamic labels with non-string typed arguments #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SimonMarquis wants to merge 3 commits into from
Closed

Fix regression in dynamic labels with non-string typed arguments #636

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d5acbb
Fix regression in dynamic labels with non-string typed arguments
SimonMarquis Dec 16, 2023
eaa1c1e
Add regression test
SimonMarquis Dec 16, 2023
f455c6d
remove trailing spaces
SimonMarquis Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix regression in dynamic labels with non-string typed arguments 
Regression introduced in 76f9009
Reported in https://issuetracker.google.com/issues/316676794
  • Loading branch information
@SimonMarquis
SimonMarquis authored Dec 16, 2023
commit 7d5acbb0c0798ccffea91830fa69ee6ce025e99f
3 changes: 2 additions & 1 deletion navigation/navigation-common/src/main/java/androidx/navigation/NavDestination.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,7 +635,8 @@ public open class NavDestination(
val value = context.getString(bundle.getInt(argName))
builder.append(value)
} else {
builder.append(bundle.getString(argName))
@Suppress("DEPRECATION")
builder.append(bundle[argName].toString())
}
} else {
throw IllegalArgumentException(
Expand Down