Skip to content

[Navigation] Introduce NavBackStackEntry#provideToCompositionLocals #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jossiwolf wants to merge 8 commits into from
Closed

[Navigation] Introduce NavBackStackEntry#provideToCompositionLocals #175

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
be27bc8
Introduce new NavBackStackEntry#provideToCompositionLocals extension …
jossiwolf May 5, 2021
be4bf48
Provide a default value for NavBackStackEntry#provideToCompositionLoc…
jossiwolf May 6, 2021
3755c15
Use TestNavigatorState to set up NavBackStackEntry instead of the ugl…
jossiwolf May 6, 2021
6dc8b2c
Extract back stack entry creation into test-private method
jossiwolf May 6, 2021
2d31918
Add testNonSaveableValueInContentIsNotSaved to save a non-saveable va…
jossiwolf May 6, 2021
f57fd49
Update API after providing default param
jossiwolf May 6, 2021
8c2a3d7
Rename provideToCompositionLocals to CompositionLocalProvider to adhe…
jossiwolf May 6, 2021
a8100a0
Rename CompositionLocalProvider to LocalOwnersProvider and make its s…
jossiwolf May 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add testNonSaveableValueInContentIsNotSaved to save a non-saveable va… 
…lue isn't saved and restored

Change-Id: Ib31cc443174d18912e55ac64e354f6721c4b1bb1
  • Loading branch information
@jossiwolf
jossiwolf committed May 6, 2021
commit 2d31918e9aad5dce180d88189caad6f907131e30
27 changes: 27 additions & 0 deletions ...compose/src/androidTest/java/androidx/navigation/compose/NavBackStackEntryProviderTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,33 @@ class NavBackStackEntryProviderTest {
assertThat(array).isEqualTo(intArrayOf(1))
}

@Test
fun testNonSaveableValueInContentIsNotSaved() {
val backStackEntry = createBackStackEntry()
val restorationTester = StateRestorationTester(composeTestRule)
var nonSaveable: IntArray? = null
val initialValue = intArrayOf(10)

restorationTester.setContent {
val saveableStateHolder = rememberSaveableStateHolder()
backStackEntry.provideToCompositionLocals(saveableStateHolder) {
nonSaveable = remember { initialValue }
}
}

assertThat(nonSaveable).isEqualTo(initialValue)

composeTestRule.runOnUiThread {
nonSaveable!![0] = 1
// we null it to ensure recomposition happened
nonSaveable = null
}

restorationTester.emulateSavedInstanceStateRestore()

assertThat(nonSaveable).isEqualTo(initialValue)
}

private fun createBackStackEntry(): NavBackStackEntry {
val testNavigator = TestNavigator()
val testNavigatorState = TestNavigatorState()
Expand Down