Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

#475 - Rest Authentication #579

Merged
DayS merged 17 commits into from
Jul 12, 2013
Merged

#475 - Rest Authentication #579

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
d23a232
Add new annotations
dhleong May 4, 2013
8122abf
Init some internal structures, add an annotation to tests
dhleong May 4, 2013
37ea732
Allow full urls in @Post, etc. to be specified and handled correctly
dhleong May 4, 2013
63d51ee
Give entity a var so we can pull cookies from it if needed
dhleong May 4, 2013
dd1397b
Implement SetsCookie, only using an Entity instance if needed
dhleong May 5, 2013
c377bb5
Implement RequiresCookieInUrl, and prepare for a few others
dhleong May 5, 2013
d73107e
Implement RequiresCookie and RequiresHeader
dhleong May 5, 2013
0cab243
Implement RequiresAuthorization
dhleong May 5, 2013
aae71df
Implement setters and getters for cookies and headers and validate them
dhleong May 5, 2013
aac6b43
Implement setAuthentication with validation
dhleong May 5, 2013
0afc92d
Implement setHttpBasicAuth method
dhleong May 5, 2013
0d2dabd
Fix some validation; ensure HttpHeaders for auth
dhleong May 5, 2013
b768498
Properly handle returned cookie values (extract only ACTUAL value)
dhleong May 5, 2013
a0986a2
Add license headers
dhleong May 5, 2013
8c517c1
Add some functional tests for new authenticated rest stuff
dhleong May 26, 2013
7bbac6c
Merge branch 'develop' of github.com:excilys/androidannotations into …
dhleong Jun 9, 2013
01dc8c8
Merge branch 'develop' into 475_Rest_Authentication
dhleong Jun 9, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Implement setHttpBasicAuth method
  • Loading branch information
@dhleong
dhleong committed May 5, 2013
commit 0afc92d5cc106bc77dba277bb723780e5fc4190a
2 changes: 1 addition & 1 deletion ...tions/androidannotations/src/main/java/org/androidannotations/helper/ValidatorHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -824,7 +824,7 @@ public void unannotatedMethodReturnsRestTemplate(TypeElement typeElement, IsVali
VariableElement secondParameter = parameters.get(1);
if (!(firstParameter.asType().toString().equals(CanonicalNameConstants.STRING) && secondParameter.asType().toString().equals(CanonicalNameConstants.STRING))) {
valid.invalidate();
annotationHelper.printError(enclosedElement, "The method to set headers or cookies should have only String parameters on a " + TargetAnnotationHelper.annotationName(Rest.class) + " annotated interface");
annotationHelper.printError(enclosedElement, "The method to set headers, cookies, or HTTP Basic Auth should have only String parameters on a " + TargetAnnotationHelper.annotationName(Rest.class) + " annotated interface");
}
} else {
valid.invalidate();
Expand Down
22 changes: 22 additions & 0 deletions ...ndroidannotations/src/main/java/org/androidannotations/processing/rest/RestProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,28 @@ public void process(Element element, JCodeModel codeModel, EBeansHolder eBeansHo
}
}

// Implement setHttpBasicAuth method
for (ExecutableElement method : methods) {
List<? extends VariableElement> parameters = method.getParameters();
if (parameters.size() == 2 && method.getReturnType().getKind() == TypeKind.VOID) {
VariableElement firstParameter = parameters.get(0);
VariableElement secondParameter = parameters.get(1);
if (firstParameter.asType().toString().equals(STRING) && secondParameter.asType().toString().equals(STRING) && method.getSimpleName().toString().equals("setHttpBasicAuth")) {
JMethod setBasicAuthMethod = holder.restImplementationClass.method(JMod.PUBLIC, codeModel.VOID, method.getSimpleName().toString());
setBasicAuthMethod.annotate(Override.class);

JVar userParam = setBasicAuthMethod.param(stringClass, firstParameter.getSimpleName().toString());
JVar passParam = setBasicAuthMethod.param(stringClass, secondParameter.getSimpleName().toString());

JClass basicAuthClass = eBeansHolder.refClass("org.springframework.http.HttpBasicAuthentication");
JInvocation basicAuthentication = JExpr._new(basicAuthClass).arg(userParam).arg(passParam);

setBasicAuthMethod.body().assign(_this().ref(holder.authenticationField), basicAuthentication);
break; // Only one implementation
}
}
}

// Implement setAuthentication method
for (ExecutableElement method : methods) {
List<? extends VariableElement> parameters = method.getParameters();
Expand Down
2 changes: 2 additions & 0 deletions ...tions/functional-test-1-5/src/main/java/org/androidannotations/test15/rest/MyService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,4 +230,6 @@ ResponseEntity<Event[][]> getEventsArrayOfArrays2(String location, int year)
String getHeader(String headerName);

void setAuthentication(HttpAuthentication auth);

void setHttpBasicAuth(String username, String password);
}