Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

Cancel background tasks #569

Merged
DayS merged 17 commits into from
Jun 9, 2013
Merged

Cancel background tasks #569

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
c201130
Immediate and delayed executors unification
rom1v Apr 18, 2013
879f196
Serial execution in background feature
rom1v Apr 18, 2013
2ded3aa
Test for @Background(serial="some_id")
rom1v Apr 18, 2013
d39e77d
Comment typo fix
rom1v Apr 19, 2013
2045e41
Use SystemClock.sleep()
rom1v Apr 19, 2013
5254f56
Better task manager implementation
rom1v Apr 21, 2013
1ab7373
Factorize surround with try/catch generation
rom1v Apr 22, 2013
ec9fea3
Directly generate Task instantiation
rom1v Apr 22, 2013
99ca871
Cancellable background tasks
rom1v Apr 21, 2013
0ec12b0
Tests for @Background attributes
rom1v Apr 22, 2013
dbd7caf
Do not fail if cancellation is not supported
rom1v Apr 22, 2013
aa2fe11
Comment bugfixes
rom1v May 21, 2013
fddcc1b
Cast into a local variable before dereferencing
rom1v May 22, 2013
33b3cf4
Remove useless comment
rom1v May 22, 2013
75b1516
Refactor targetTime -> targetTimeMillis
rom1v May 22, 2013
f3a5718
Refactor delay -> remainingDelay
rom1v May 22, 2013
4161c62
Javadoc for @Background annotation
rom1v May 22, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Do not fail if cancellation is not supported 
If the executor is replaced by another not supporting cancellation (not
extending ExecutorService), it failed the first time a task with a
non-null id was requested.

Now, it just warns during cancellation.
  • Loading branch information
@rom1v
rom1v committed Apr 22, 2013
commit dbd7cafdefb215c02b3242203c8f4481855bbbb1
9 changes: 6 additions & 3 deletions ...tions/androidannotations/src/main/java/org/androidannotations/api/BackgroundExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,12 @@
import java.util.concurrent.ScheduledExecutorService;
import java.util.concurrent.TimeUnit;

import android.util.Log;

public class BackgroundExecutor {

private static final String TAG = "BackgroundExecutor";

private static Executor executor = Executors.newScheduledThreadPool(2 * Runtime.getRuntime().availableProcessors());

private static final List<Task> tasks = new ArrayList<Task>();
Expand Down Expand Up @@ -82,9 +86,6 @@ public static synchronized void execute(Task task) {
if (task.serial == null || !hasSerialRunning(task.serial)) {
task.executionAsked = true;
future = directExecute(task, task.delay);
if (task.id != null && future == null) {
throw new IllegalArgumentException("The executor set does not support task cancellation");
}
}
if (task.id != null || task.serial != null) {
/* keep task */
Expand Down Expand Up @@ -196,6 +197,8 @@ public static synchronized void cancelAll(String id, boolean mayInterruptIfRunni
tasks.remove(i);
if (task.future != null) {
task.future.cancel(mayInterruptIfRunning);
} else if (task.executionAsked) {
Log.w(TAG, "A task with id " + task.id + " cannot be cancelled (the executor set does not support it)");
}
}
}
Expand Down