Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

Implements @RootFragment annotation support. - #2202

Merged
dodgex merged 1 commit into
androidannotations:developfrom
smaugho:1636_rootfragment_implementation_for_ebean
Feb 22, 2019
Merged

Implements @RootFragment annotation support.#2202
dodgex merged 1 commit into
androidannotations:developfrom
smaugho:1636_rootfragment_implementation_for_ebean

Conversation

@smaugho

@smaugho smaugho commented Feb 14, 2019

Copy link
Copy Markdown
Contributor

I've implemented the support for a @RootFragment which solves the issue #1636 . Please let me know about any question/suggestion regarding the solution.

Thanks.

@smaugho smaugho mentioned this pull request Feb 14, 2019
Closed
@smaugho
smaugho force-pushed the 1636_rootfragment_implementation_for_ebean branch from 11aa5ee to 93ef3ed Compare February 15, 2019 00:05
dodgex
dodgex suggested changes Feb 15, 2019
View reviewed changes
Comment thread ...re/androidannotations-api/src/main/java/org/androidannotations/annotations/RootFragment.java Outdated
Comment thread ...tations-core/androidannotations/src/main/java/org/androidannotations/holder/EBeanHolder.java
Comment thread ...otations/src/main/java/org/androidannotations/internal/core/handler/RootFragmentHandler.java Outdated
@smaugho
smaugho force-pushed the 1636_rootfragment_implementation_for_ebean branch from 93ef3ed to 6a485f0 Compare February 15, 2019 11:33
WonderCsabo
WonderCsabo suggested changes Feb 15, 2019
View reviewed changes

@WonderCsabo WonderCsabo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add compile time tests to verify validation and that correct code compiles, and runtime tests as well.

Comment thread ...re/androidannotations-api/src/main/java/org/androidannotations/annotations/RootFragment.java Outdated
Comment thread ...re/androidannotations-api/src/main/java/org/androidannotations/annotations/RootFragment.java Outdated
Comment thread ...tations-core/androidannotations/src/main/java/org/androidannotations/holder/EBeanHolder.java Outdated
Comment thread ...tations-core/androidannotations/src/main/java/org/androidannotations/holder/EBeanHolder.java Outdated
Comment thread ...otations/src/main/java/org/androidannotations/internal/core/handler/RootFragmentHandler.java
This was referenced Feb 15, 2019
Closed
Merged
@smaugho
smaugho force-pushed the 1636_rootfragment_implementation_for_ebean branch 2 times, most recently from c79722f to 02c0b61 Compare February 16, 2019 19:38
WonderCsabo
WonderCsabo suggested changes Feb 16, 2019
View reviewed changes

@WonderCsabo WonderCsabo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the extensive tests! I added some small review comments.

Comment thread ...e/androidannotations/src/test/java/org/androidannotations/rootfragment/RootFragmentTest.java
Comment thread ...nnotations-testutils/src/main/java/org/androidannotations/testutils/ProcessorTestHelper.java
Comment thread ...nnotations-test/src/test/java/org/androidannotations/test/rootfragment/RootFragmentTest.java Outdated
Comment thread ...rc/main/java/org/androidannotations/test/rootfragment/ActivityWithBeansWithRootFragment.java Outdated
Comment thread ...ore/androidannotations/src/test/java/org/androidannotations/rootfragment/CustomFragment.java Outdated
@smaugho
smaugho force-pushed the 1636_rootfragment_implementation_for_ebean branch 3 times, most recently from a7907e6 to 7f374b9 Compare February 16, 2019 22:07
@smaugho

smaugho commented Feb 16, 2019

Copy link
Copy Markdown
Contributor Author

@WonderCsabo Travis failed this time but seems to be due to some missing copyrights in some other files

@smaugho

smaugho commented Feb 16, 2019

Copy link
Copy Markdown
Contributor Author

I will add them..

@smaugho
smaugho force-pushed the 1636_rootfragment_implementation_for_ebean branch from 7f374b9 to 8738fce Compare February 16, 2019 22:30
@WonderCsabo

WonderCsabo commented Feb 16, 2019

Copy link
Copy Markdown
Member

Thanks, that was my fault. I forgot to rebase the branch to include the license check...

@WonderCsabo

WonderCsabo commented Feb 16, 2019

Copy link
Copy Markdown
Member

BTW, next time please create separate commits for unrelated changes such as this.

WonderCsabo
WonderCsabo previously approved these changes Feb 17, 2019
View reviewed changes
@smaugho
smaugho force-pushed the 1636_rootfragment_implementation_for_ebean branch 2 times, most recently from 4da9e81 to 6e5afd6 Compare February 17, 2019 21:18
@WonderCsabo

WonderCsabo commented Feb 17, 2019

Copy link
Copy Markdown
Member

This depends on #2211 , right?

@smaugho

smaugho commented Feb 17, 2019

Copy link
Copy Markdown
Contributor Author

Right now yes 😅

@dodgex

dodgex commented Feb 18, 2019

Copy link
Copy Markdown
Member

#2211 has been merged.

@smaugho

smaugho commented Feb 18, 2019

Copy link
Copy Markdown
Contributor Author

I will rebase this branch, to simplify its revision.

@WonderCsabo

WonderCsabo commented Feb 19, 2019

Copy link
Copy Markdown
Member

@smaugho please rebase this.

@smaugho
smaugho force-pushed the 1636_rootfragment_implementation_for_ebean branch from 6e5afd6 to 8efbb50 Compare February 19, 2019 09:32
@smaugho

smaugho commented Feb 19, 2019

Copy link
Copy Markdown
Contributor Author

Done

@WonderCsabo
WonderCsabo requested a review from dodgex February 22, 2019 09:49
@dodgex
dodgex merged commit 07f7be9 into androidannotations:develop Feb 22, 2019
@dodgex

dodgex commented Feb 22, 2019

Copy link
Copy Markdown
Member

Thanks! :)

@dodgex dodgex added this to the 4.7.0 milestone Feb 22, 2019
@smaugho
smaugho deleted the 1636_rootfragment_implementation_for_ebean branch February 24, 2019 14:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@dodgex dodgex dodgex approved these changes
@WonderCsabo WonderCsabo WonderCsabo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@smaugho @WonderCsabo @dodgex