This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Repository navigation
Update Kotlin example - #2029
Merged
dodgex merged 2 commits intoJul 30, 2017
Merged
Conversation
Member
|
Thank you, could you also update the versions in the other samples? To have them in sync. |
ahornerr
approved these changes
Jul 26, 2017
Member
Author
|
Maybe because of this, we should not remove the kapt block from the example, because it fixes flavors with the stable Android Gradle plugin at least. |
Member
|
Maybe we should try to enhance the manifest finder to support the new(?) behaviour of I have an idea that could work, if i correctly understand the problem with the directories. I'll see if i get a hand on it this evening or tomorrow. |
Member
Author
|
@dodgex thanks! |
Member
WonderCsabo
force-pushed
the
updateKotlinExample
branch
from
July 30, 2017 09:18
45055d0 to
1e2e269
Compare
The manifest file is now found automatically, configuring it by hand may cause issues.
Member
Author
|
@dodgex updated. |
Member
|
There is a travis issue due to the upgrade to 26 build tools. :/ |
WonderCsabo
force-pushed
the
updateKotlinExample
branch
from
July 30, 2017 11:28
1e2e269 to
1cce92e
Compare
Member
Author
|
@dodgex build fixed. |
dodgex
approved these changes
Jul 30, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The manifest file is now found automatically, configuring it by hand
may cause issues.