Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

Fix missing varparam in super calls #1705

Merged
WonderCsabo merged 2 commits into from
Feb 25, 2016
Merged

Fix missing varparam in super calls #1705

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5a1874
Add missing varparam to super call when overriding
WonderCsabo Feb 25, 2016
9104851
Make varparams final in overriden methods
WonderCsabo Feb 25, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add missing varparam to super call when overriding 
This commits fixes a regression introduced in 240c51e.
We use the dedicated JMethod#varParam() API to add the variable length
parameter, however we only added normal parameters to the super
call. Now we also add the dedicated varparam to the super call as well.
  • Loading branch information
@WonderCsabo
WonderCsabo committed Feb 25, 2016
commit d5a1874b4d38a48d8f7e2458f18fe7f50151be59
4 changes: 4 additions & 0 deletions ...re/androidannotations/src/main/java/org/androidannotations/helper/APTCodeModelHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,10 @@ public JInvocation getSuperCall(GeneratedClassHolder holder, JMethod superMethod
superCall.arg(param);
}

if (superMethod.hasVarArgs()) {
superCall.arg(superMethod.varParam());
}

return superCall;
}

Expand Down